public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)
Date: Tue, 9 Aug 2016 14:28:50 +0100
Message-ID: <CA+OCxoym1Afqb6P1fFBdbpqy1H2GnPUWZTdkKGG4fMh+0ncqwA@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmoy23TqokXu8ppWXams2LHyyoDOze8CH1t+Xk2CuTUQwuA@mail.gmail.com>
References: <CAKKotZTJY1zV+Edi_oJ3611WJVq4Qi4RXi00Ddzkp6iWJardMA@mail.gmail.com>
<CA+OCxowMGSBwuAVj96y4eQ7FSFOnv943bkJZVzZ=SN8Rb3St3g@mail.gmail.com>
<CAG7mmowVhXbusQ1ZO879GxNvXR0CoGETM27mgpiUebZzLzmMMQ@mail.gmail.com>
<CA+OCxoy8FKgAT2RVw-yctkJcURmLKpk2bBcGqbneP+=F87BtNw@mail.gmail.com>
<CAG7mmoykBtHBnzHhDCbJ2342MpggKx95Ng21Evy90FmcEynjVQ@mail.gmail.com>
<CA+OCxoxU_n7oCMDv_gcAWfXpVYU_m--JjZbYYC1cuFYJPhW7wQ@mail.gmail.com>
<CAG7mmoy23TqokXu8ppWXams2LHyyoDOze8CH1t+Xk2CuTUQwuA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Tue, Aug 9, 2016 at 2:21 PM, Ashesh Vashi <[email protected]>
wrote:
> On Tue, Aug 9, 2016 at 6:47 PM, Dave Page <[email protected]> wrote:
>
>>
>>
>> On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi <
>> [email protected]> wrote:
>>
>>> On Tue, Aug 9, 2016 at 6:34 PM, Dave Page <[email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
>>>>>> <[email protected]> wrote:
>>>>>> > Hi,
>>>>>> >
>>>>>> > PFA patch to fix the issue where message panel was showing
>>>>>> incomplete info.
>>>>>> > We may still miss some messages from Psycopg2 driver due to limited
>>>>>> size of
>>>>>> > notices queue.
>>>>>> > (RM#1523)
>>>>>>
>>>>>> A few thoughts on this (mostly based on my discussions with Ashesh):
>>>>>>
>>>>>> 1) You seem to have removed the poll delay. I assume that is to try to
>>>>>> avoid missing messages? Can we re-introduce the delay (to avoid
>>>>>> excessive network requests), but collect messages while we're waiting?
>>>>>>
>>>>> Using thread?
>>>>> Start a thread during the timeout?
>>>>>
>>>>
>>>> Not necessarily. If we want a 2 second polling delay, we could just
>>>> sleep for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages,
>>>> <repeat...> return to client.
>>>>
>>> That's a very huge delay in practical.
>>> We were hardly waiting for during poll (that was in milliseconds), but -
>>> still we were loosing a lot of the messages. (a lot more from the current
>>> implementation).
>>>
>>
>> What was the original delay? Now there appears to be none at all.
>>
> That was 10 milliseconds
>
Hmm, Ok - for some reason I thought it was much longer. Ignore that point
then :-)
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (14+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)
In-Reply-To: <CA+OCxoym1Afqb6P1fFBdbpqy1H2GnPUWZTdkKGG4fMh+0ncqwA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox