public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Required inputs in issue #6138
Date: Thu, 15 Jun 2023 10:40:43 +0100
Message-ID: <CA+OCxoymw-hKw8nYbt-nTi=6h7tB_dRPyaQL-ib2s2uPzcoxTQ@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AMGqtR9QVkaJuu2x7fccCpFWOzAz56DHAgGdx1-=us7dg@mail.gmail.com>
References: <CAOBg0AMGqtR9QVkaJuu2x7fccCpFWOzAz56DHAgGdx1-=us7dg@mail.gmail.com>

On Wed, 14 Jun 2023 at 13:43, Nikhil Mohite <[email protected]>
wrote:

> Hi Hacker,
>
> I am currently working on issue #6138
> <https://github.com/pgadmin-org/pgadmin4/issues/6138;, which was fixed
> earlier but the fix was not correct so working on it again.
> Steps to reproduce the issue:
> 1. Open *View/Edit Data *for *table1*
> 2. Open the PSQL tool delete the same *table1 *and recreates the same
> name table *table1* and try to re-execute the query from the
> already opened *View/Edit data *panel.
> 3. pgAdmin throws an error in the Messages tab *List index out of range *(pgAdmin
> query to get table columns from Postgres based on *table oid* which was
> deleted and the return result is empty which is not handled in pgAdmin)*.*
>
> Approach to fix this issue:
> 1. If the user re-executes the query from already opened *View/Edit data* we
> should fetch the table details by using *schema and table name (not using
> table oid)* and show the newly created table records in the result.
> (This will only fix an issue with *View/Edit Data *however if the user
> switches to properties or some other panel it user will still get an error
> notification with content *"could not find the specified table."*)
>

I think this is fine. The View/Edit data window shows the query with
table/schema name after all, so the user should expect it to work.

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com


view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Required inputs in issue #6138
  In-Reply-To: <CA+OCxoymw-hKw8nYbt-nTi=6h7tB_dRPyaQL-ib2s2uPzcoxTQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox