public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11
Date: Fri, 6 Jul 2018 13:14:42 +0100
Message-ID: <CA+OCxoys9P6nEcTXuZ2Bps70auNCbshdp3vmxWycnzT16OV-Bw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDenxf+JgEUmoPCLT9uLFx7tQtkg+q5M-v+EAnCp6DJykg@mail.gmail.com>
References: <CANxoLDdnaPB8gt-v+4aVY2urY8suGqK=pFiWFZ-Agxkgkx_VYw@mail.gmail.com>
<CA+OCxozxjz+m=zy_AN4QPQtNHKuYTpQ6YpihoS=ugpzLe_jvEQ@mail.gmail.com>
<CANxoLDcKr_A+gCBwgdG6GGrc78Rm2mtLsvmL-pEx7UPSPg8kBA@mail.gmail.com>
<CA+OCxow4L5AL8QNYxVckjGVtaN9h+J+72Kg_wjuQ+qJA5ffShw@mail.gmail.com>
<CANxoLDd7P5QKxbhbQ93Hw=gF0NQdFt2pyy5XnQ_LThTVmk8Bnw@mail.gmail.com>
<CA+OCxox5_-7PK787BN9K_OQf_8Bo54Arsw-jFjT8sDsZFgmTBw@mail.gmail.com>
<CANxoLDctoTPfKdhV8t06y=8ROtZVSfifhsbSyCot0Jga9LRHDg@mail.gmail.com>
<CANxoLDeJXAQuG=L50jR=e82Fh89VzbM94Sj90ECENrurBFV5bw@mail.gmail.com>
<CANxoLDco102yaz9Ez0jS5XTCyQNg6a4f1Q35UawpZCf2G1SFEw@mail.gmail.com>
<CA+OCxoyfAKdfMD2aEZziXGU=DGBVw+ApXq7Sa6YnyOESJLVjdw@mail.gmail.com>
<CANxoLDenxf+JgEUmoPCLT9uLFx7tQtkg+q5M-v+EAnCp6DJykg@mail.gmail.com>
Thanks, patch applied!
On Fri, Jul 6, 2018 at 6:44 AM, Akshay Joshi <[email protected]>
wrote:
> Hi
>
> On Thu, Jul 5, 2018 at 7:17 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Looks good to me - the only remaining issue is that the button still
>> isn't the same colours as the zoom ones. I haven't found all the
>> differences, but there seems to be an 'opacity: 0.5" on the stats area, and
>> the disabled attribute is still being set.
>>
>
> I have set the disabled attribute, so that the button shouldn't be
> clickable and because of that there is difference in colour. 'opacity:
> 0.5' is also there for zoom area. I have fixed the issue by removing
> disabled attribute and add '
>
> *pointer-events: none*' for the statistics button. Attached is the patch
> please review it.
>
>>
>> On Thu, Jul 5, 2018 at 11:21 AM, Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Dave
>>>
>>> As per discussion attached is the modified patch with following review
>>> comments has been fixed :
>>>
>>> - Hide statistics button if not applicable(no statistics to show).
>>> - Extract 'StatisticsModel' into a separate file and added jasmine
>>> test for this.
>>>
>>>
>>>
>>>
>>> On Tue, Jul 3, 2018 at 6:40 PM, Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Please ignore the previous patch, I have made some more changes related
>>>> to background colour on enabled/disabled state.
>>>> Attached is the modified patch. Please review it.
>>>>
>>>> On Tue, Jul 3, 2018 at 12:35 PM, Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> On Mon, Jul 2, 2018 at 4:10 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Sat, Jun 30, 2018 at 9:15 AM, Akshay Joshi <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave
>>>>>>>
>>>>>>> On Fri, Jun 29, 2018 at 7:45 PM, Dave Page <[email protected]>
>>>>>>> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Jun 29, 2018 at 3:12 PM, Akshay Joshi <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave
>>>>>>>>>
>>>>>>>>> On Fri, Jun 29, 2018 at 6:56 PM, Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi
>>>>>>>>>>
>>>>>>>>>> On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Hackers,
>>>>>>>>>>>
>>>>>>>>>>> Attached is the patch to fix the RM #3397 Add support for JIT
>>>>>>>>>>> stats in EXPLAIN output in PG11. Please review it.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> A couple of immediate thoughts:
>>>>>>>>>>
>>>>>>>>>> - When the canvas is first rendered, there's a vertical scrollbar
>>>>>>>>>> now. As soon as I mouseover the new icon, it vanishes and the icon jumps to
>>>>>>>>>> the right.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Will look into it. Vertical scrollbar comes even if you
>>>>>>>>> remove my patch and try to hover any image.
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> - The icon seems lighter than the other controls on the left.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Same css has been applied, only difference is button is
>>>>>>>>> disabled.
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> - The icon isn't disabled when there is no info to show.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Button is always disabled, I have just change the opacity.
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Thanks.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>> Maybe - but I can still click it and it reacts as if it's active.
>>>>>>>> It may be lighter to indicate that it's disabled, but its not behaving as
>>>>>>>> such.
>>>>>>>>
>>>>>>>
>>>>>>> Attached is the modified patch. Please review it.
>>>>>>>
>>>>>>
>>>>>> The button still changes foreground colour on mouseover when
>>>>>> disabled. I think it needs to be completely non-reactive when disabled. It
>>>>>> should also be a noticably lighter shade when disabled; right now it seems
>>>>>> to be darker than the other buttons (see attached).
>>>>>>
>>>>>
>>>>> Attached is the modified patch. Please review it.
>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect *
>>>>>
>>>>>
>>>>>
>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect *
>>>>
>>>>
>>>>
>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (12+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11
In-Reply-To: <CA+OCxoys9P6nEcTXuZ2Bps70auNCbshdp3vmxWycnzT16OV-Bw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox