public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11
Date: Fri, 29 Jun 2018 15:15:59 +0100
Message-ID: <CA+OCxow4L5AL8QNYxVckjGVtaN9h+J+72Kg_wjuQ+qJA5ffShw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcKr_A+gCBwgdG6GGrc78Rm2mtLsvmL-pEx7UPSPg8kBA@mail.gmail.com>
References: <CANxoLDdnaPB8gt-v+4aVY2urY8suGqK=pFiWFZ-Agxkgkx_VYw@mail.gmail.com>
	<CA+OCxozxjz+m=zy_AN4QPQtNHKuYTpQ6YpihoS=ugpzLe_jvEQ@mail.gmail.com>
	<CANxoLDcKr_A+gCBwgdG6GGrc78Rm2mtLsvmL-pEx7UPSPg8kBA@mail.gmail.com>

On Fri, Jun 29, 2018 at 3:12 PM, Akshay Joshi <[email protected]
> wrote:

> Hi Dave
>
> On Fri, Jun 29, 2018 at 6:56 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix the RM #3397 Add support for JIT stats in
>>> EXPLAIN output in PG11. Please review it.
>>>
>>
>> A couple of immediate thoughts:
>>
>> - When the canvas is first rendered, there's a vertical scrollbar now. As
>> soon as I mouseover the new icon, it vanishes and the icon jumps to the
>> right.
>>
>
>      Will look into it. Vertical scrollbar comes even if you remove my
> patch and try to hover any image.
>
>>
>> - The icon seems lighter than the other controls on the left.
>>
>
>      Same css has been applied, only difference is button is disabled.
>
>>
>> - The icon isn't disabled when there is no info to show.
>>
>
>      Button is always disabled, I have just change the opacity.
>
>>
>> Thanks.
>>
>
Maybe - but I can still click it and it reacts as if it's active. It may be
lighter to indicate that it's disabled, but its not behaving as such.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11
  In-Reply-To: <CA+OCxow4L5AL8QNYxVckjGVtaN9h+J+72Kg_wjuQ+qJA5ffShw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox