public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Navnath Gadakh <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Kanchan Mohitey <[email protected]>
Subject: Re: pgAdmin IV : Unittest modular patch (Domains and Tables nodes)
Date: Thu, 1 Sep 2016 12:14:08 +0100
Message-ID: <CA+OCxoysHrwNcRvFiR9VbGbRRs__h=gW=mzPrTN3j01y4KR5TA@mail.gmail.com> (raw)
In-Reply-To: <CAOAJCYo0XurY7XrPN_Vkdt9oAQ-KoSdcrunZi=damwTN7h0deQ@mail.gmail.com>
References: <CAOAJCYrxhfbsjCnTQt0r6DuwxGTBO1VzGvym-rWjnwxU5nqtOg@mail.gmail.com>
	<CA+OCxoztJ9=RaFLVH0XDanar8S0pB5wOZ3h8LRWc0YPpO=jR5w@mail.gmail.com>
	<CAOAJCYo0XurY7XrPN_Vkdt9oAQ-KoSdcrunZi=damwTN7h0deQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

Please separate the cleanup from the new tests. Each patch should have just
one feature/focus/fix.

Thanks.

On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh <
[email protected]> wrote:

> Hello Dave,
>     Object cleanup work is completed in above patch. I am working on enhanced
> summary work, once that's complete I will send the revised patch.
>
> Thanks!
>
> On Thu, Sep 1, 2016 at 3:57 PM, Dave Page <[email protected]>
> wrote:
>
>> Per my earlier email to Priyanka, I'm not going to commit any more test
>> cases until the existing issues are resolved and the enhanced summary and
>> object cleanup work is complete, otherwise it's just taking too much time
>> unnecessarily.
>>
>> Please re-test and resubmit this patch once that work is complete.
>>
>> Thanks.
>>
>> On Tue, Aug 30, 2016 at 1:02 PM, Navnath Gadakh <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>        Please find the patch API unit test cases for Domain & Tables
>>> Nodes.
>>>
>>> This patch also includes code to drop the all objects(like database,
>>> roles, tablespace & server) created during the test suite run.
>>>
>>> *To run the test suite for domain node:*
>>>  python regression/runtests.py --pkg browser.server_groups.servers.
>>> databases.schemas.domains
>>>
>>>
>>> *To run the test suite for tables node:*
>>>   python regression/runtests.py --pkg browser.server_groups.
>>> servers.databases.schemas.tables
>>>
>>> *To run the test suite for all nodes *(Comment the all test code in
>>> 'synonyms' node i.e. Code under 'tests' directory as its partially
>>> completed):
>>>   python regression/runtests.py
>>>
>>>
>>> --
>>> Thanks,
>>> Navnath Gadakh
>>> Software Engineer
>>> EnterpriseDB Corporation
>>> Mobile: +91 9975389878
>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin IV : Unittest modular patch (Domains and Tables nodes)
  In-Reply-To: <CA+OCxoysHrwNcRvFiR9VbGbRRs__h=gW=mzPrTN3j01y4KR5TA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox