public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Akshay Joshi <[email protected]>
Subject: Re: PATCH: Login/Group Role Node
Date: Tue, 2 Feb 2016 09:55:26 +0000
Message-ID: <CA+OCxoytmkdf3a-ngUz1r2b_7OU1aC3bCv48T=hofQKM-PYt=A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAG7mmoy=Wd5xHV=e734d4=8pqS7BOKyL8mUdh-5AMfs84Tm6VQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

On Tue, Feb 2, 2016 at 9:22 AM, Murtuza Zabuawala <
[email protected]> wrote:

> Hi Ashesh,
>
> I also found that we are not handling group role in macro templates.
>
> Steps to re-produce the issue:
> 1) Create a sample Group Role.
>     name : my_group
>
> Click 'Ok' to create.
>
> 2) Go to privilege tab (in my case Database node)
> - Click on Add button
> - Select my_group (Group) from options
> - grant any priviledges
>
> 3) Go to modified SQL tab
>
> - You will see wrong SQL generated
> GRANT ALL ON DATABASE postgres *TO* my_group WITH GRANT OPTIONS
>
> *Expected SQL:*
> GRANT ALL ON DATABASE postgres *TO GROUP* my_group WITH GRANT OPTIONS
>

Isn't GROUP just a noise word that's there for backwards compatibility with
pre-role releases?



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: PATCH: Login/Group Role Node
  In-Reply-To: <CA+OCxoytmkdf3a-ngUz1r2b_7OU1aC3bCv48T=hofQKM-PYt=A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox