public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM3575] Right click does not work on database node if server name changed
Date: Thu, 10 Jan 2019 11:53:05 +0530
Message-ID: <CA+OCxoywzbQ9NPAhgDUfSkDvSnfxogkg8dadU+JeRFK5GnCg=Q@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mBN5ZYxTZ2wcWuJ6RLvsffG+iha9Zb8bRJok=-cuNZ7w@mail.gmail.com>
References: <CAM9w-_mBN5ZYxTZ2wcWuJ6RLvsffG+iha9Zb8bRJok=-cuNZ7w@mail.gmail.com>

Thanks - patch applied.

On Wed, Jan 9, 2019 at 4:16 PM Aditya Toshniwal
<[email protected]> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix the issue where changing the name (or any visible property on tree) of the server node breaks the context menu on the database nodes.
>
> The user information of the server is updated on successful connection. Here, the data is updated on the aciTreeNode(domNode). But, in the context menu the user data is referred from TreeNode object (a wrapper to aciTreeNode). After checking the code (and a lot of debugging) it was found that aciTreeNode and TreeNode point to two different data(I don't know why). Every time you change one, it should be synced to other, which is not done everywhere.
> Changes are done to point both aciTreeNode and TreeNode data to the same data object.
>
> Kindly review.
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM3575] Right click does not work on database node if server name changed
  In-Reply-To: <CA+OCxoywzbQ9NPAhgDUfSkDvSnfxogkg8dadU+JeRFK5GnCg=Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox