public inbox for [email protected]help / color / mirror / Atom feed
[PGAGENT] Upgrade pgAgent from unpackaged version 4+ messages / 3 participants [nested] [flat]
* [PGAGENT] Upgrade pgAgent from unpackaged version @ 2018-06-13 04:11 Ashesh Vashi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Ashesh Vashi @ 2018-06-13 04:11 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Rushabh Lathia <[email protected]>; pgadmin-hackers Hi Dave, As per my conversation with Rushabh, we need to rename the pgagent--unpackaged--3.4.sql to pgagent--unpackaged--4.0.sql as it the current version has changed. We also need to update the schema version function for the unpackaged extension. Please find the attached patch for the same. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com; *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi; Attachments: [application/octet-stream] pgagent_extension_from_unpackaged.sql (1013B, 3-pgagent_extension_from_unpackaged.sql) download ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [PGAGENT] Upgrade pgAgent from unpackaged version @ 2018-06-13 12:40 Dave Page <[email protected]> parent: Ashesh Vashi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Dave Page @ 2018-06-13 12:40 UTC (permalink / raw) To: Ashesh Vashi <[email protected]>; +Cc: Rushabh Lathia <[email protected]>; pgadmin-hackers Thanks, applied. On Wed, Jun 13, 2018 at 5:11 AM, Ashesh Vashi <[email protected] > wrote: > Hi Dave, > > As per my conversation with Rushabh, we need to rename the > pgagent--unpackaged--3.4.sql to pgagent--unpackaged--4.0.sql as it the > current version has changed. We also need to update the schema version > function for the unpackaged extension. > > Please find the attached patch for the same. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com; > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi; > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [PGAGENT] Upgrade pgAgent from unpackaged version @ 2018-06-14 04:49 Rushabh Lathia <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Rushabh Lathia @ 2018-06-14 04:49 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers Thanks Ashesh and Dave. I verified the changes and it looks good to me. I found that newly added unpackaged file still have old file header comment. Which require change with new file name. PFA patch to fix the same. Thanks, On Wed, Jun 13, 2018 at 6:10 PM, Dave Page <[email protected]> wrote: > Thanks, applied. > > On Wed, Jun 13, 2018 at 5:11 AM, Ashesh Vashi < > [email protected]> wrote: > >> Hi Dave, >> >> As per my conversation with Rushabh, we need to rename the >> pgagent--unpackaged--3.4.sql to pgagent--unpackaged--4.0.sql as it the >> current version has changed. We also need to update the schema version >> function for the unpackaged extension. >> >> Please find the attached patch for the same. >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> <http://www.enterprisedb.com; >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi; >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- -- Rushabh Lathia Database Architect EnterpriseDB Corporation The Enterprise Postgres Company Phone: +91-20-30589494 Website: http://www.enterprisedb.com EnterpriseDB Blog: http://blogs.enterprisedb.com/ Follow us on Twitter: http://www.twitter.com/enterprisedb Attachments: [text/x-patch] unpackaged_file_header_change.patch (531B, 3-unpackaged_file_header_change.patch) download | inline diff: diff --git a/sql/pgagent--unpackaged--4.0.sql b/sql/pgagent--unpackaged--4.0.sql index 302dde4..b0e2cce 100644 --- a/sql/pgagent--unpackaged--4.0.sql +++ b/sql/pgagent--unpackaged--4.0.sql @@ -4,7 +4,7 @@ // Copyright (C) 2002 - 2018 The pgAdmin Development Team // This software is released under the PostgreSQL Licence // -// pgagent--unpackaged--3.4.sql - Convert pgAgent existing tables and functions to an extension +// pgagent--unpackaged--4.0.sql - Convert pgAgent existing tables and functions to an extension // */ ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [PGAGENT] Upgrade pgAgent from unpackaged version @ 2018-06-14 08:27 Dave Page <[email protected]> parent: Rushabh Lathia <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Dave Page @ 2018-06-14 08:27 UTC (permalink / raw) To: Rushabh Lathia <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers Thanks Rushabh - patch applied! On Thu, Jun 14, 2018 at 5:49 AM, Rushabh Lathia < [email protected]> wrote: > Thanks Ashesh and Dave. > > I verified the changes and it looks good to me. I found that newly > added unpackaged file still have old file header comment. Which > require change with new file name. > > PFA patch to fix the same. > > Thanks, > > > On Wed, Jun 13, 2018 at 6:10 PM, Dave Page <[email protected]> wrote: > >> Thanks, applied. >> >> On Wed, Jun 13, 2018 at 5:11 AM, Ashesh Vashi < >> [email protected]> wrote: >> >>> Hi Dave, >>> >>> As per my conversation with Rushabh, we need to rename the >>> pgagent--unpackaged--3.4.sql to pgagent--unpackaged--4.0.sql as it the >>> current version has changed. We also need to update the schema version >>> function for the unpackaged extension. >>> >>> Please find the attached patch for the same. >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> <http://www.enterprisedb.com; >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> <http://www.linkedin.com/in/asheshvashi; >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > -- > > Rushabh Lathia > Database Architect > EnterpriseDB Corporation > The Enterprise Postgres Company > > Phone: +91-20-30589494 > > Website: http://www.enterprisedb.com > EnterpriseDB Blog: http://blogs.enterprisedb.com/ > Follow us on Twitter: http://www.twitter.com/enterprisedb > > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2018-06-14 08:27 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2018-06-13 04:11 [PGAGENT] Upgrade pgAgent from unpackaged version Ashesh Vashi <[email protected]> 2018-06-13 12:40 ` Dave Page <[email protected]> 2018-06-14 04:49 ` Rushabh Lathia <[email protected]> 2018-06-14 08:27 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox