Re: PATCH: PGADMIN 4 - FTS templates node

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Sanket Mehta <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: PGADMIN 4 - FTS templates node
Date: Tue, 22 Mar 2016 14:41:37 +0000
Message-ID: <CA+OCxoz1aNKF_WJ=yexAiCf-E7uVpWj9EeEFm9+FcOqDVRajng@mail.gmail.com> (raw)
In-Reply-To: <CA+yw=mPxLmmpOb4TkfMr+d_WqEPJQEcCS2werBosy0kG0mj2kw@mail.gmail.com>
References: <CA+yw=mMx=HsY2K01bQmdh6i+E4hUKJJM+KZWW_4B0AhB-O8cPw@mail.gmail.com>
	<CA+yw=mNfEV51SFb6h1nb23mFD94D0HqRDyMqYE5XwuSy8DOvug@mail.gmail.com>
	<CA+OCxozUe1K9V-JF3HQ+Aj8gdEep8xhxD-GxrdkUB_k11eu55w@mail.gmail.com>
	<CA+yw=mNuzL-ZOPhN2HeM=4X5TZKjyLi+r4SXqvtfNdGo32SyhA@mail.gmail.com>
	<CA+yw=mMXCnte6_yLEgW-HKbSAa5ZhLVF1U9gr6VYwKfch3eoPQ@mail.gmail.com>
	<CA+yw=mO_GC-jPtngf1AChkWKGfU6gVG3Ag0RP3aEeLnHvV8mCA@mail.gmail.com>
	<CA+OCxoyZ68sU+hLm=THSd8afjAAxLZ0fB0fj-vtLPNvwABL-WA@mail.gmail.com>
	<CA+yw=mPy7QqwWiR-MzMqyd+Zyjca1OBZuD5k_Z+CH6ore1A-vA@mail.gmail.com>
	<CA+OCxoz+TiEg+Z3jKu6ccFf7YX7Wp71eSzr+mvefwwqdkPz5-g@mail.gmail.com>
	<CA+yw=mPxLmmpOb4TkfMr+d_WqEPJQEcCS2werBosy0kG0mj2kw@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

This seems to be fine, except:

- The icons were missing from the patch (I added them manually)

- The issue you couldn't reproduce that I reported previously still
exists. I created an FTS template per the attached screenshots, and
the SQL tab shows only "Modified SQL". The template is correctly
created though. When I edit the template, I can also successfully
rename it and update the comment, though the SQL tab still says
"Modified SQL".



On Wed, Mar 16, 2016 at 7:10 AM, Sanket Mehta
<[email protected]> wrote:
> Hi,
>
> Sorry its misunderstanding from my side.
> That node refresh on tree issue has been resolved.
>
> Patch is attached with this mail.
>
> Please do review it.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Mon, Mar 14, 2016 at 7:27 PM, Dave Page <[email protected]> wrote:
>>
>> On Mon, Mar 14, 2016 at 1:52 PM, Sanket Mehta
>> <[email protected]> wrote:
>> > Hi Dave,
>> >
>> > I have incorporated your changes.
>> > I have also tried to reproduce the Issues that you have mentioned.
>> > find the response inline.
>> >
>> > Also find revised patch having your suggested changes attached with this
>> > mail.
>> > Please do review it and let me know in case anything is missing.
>> >
>> >
>> > Regards,
>> > Sanket Mehta
>> > Sr Software engineer
>> > Enterprisedb
>> >
>> > On Fri, Mar 11, 2016 at 6:41 PM, Dave Page <[email protected]> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Thu, Mar 10, 2016 at 6:28 AM, Sanket Mehta
>> >> <[email protected]> wrote:
>> >> > Hi,
>> >> >
>> >> > PFA the patch for fts template after replacing collectionNodeModule
>> >> > with
>> >> > SchemaChildModule in __init__.py
>> >> >
>> >> > Apart from that, there was an error while updating the name of fts
>> >> > template
>> >> > which I have resolved in the same.
>> >> >
>> >> > Please do review it and let me know in case of any changes.
>> >>
>> >> I've updated the patch for consistency with others. Please find
>> >> attached. Aside from those changes, there are two issues:
>> >>
>> >> - When creating or editing a template the SQL pane just says
>> >> "--modified SQL" even when all required options are specified. The
>> >> template is created correctly though.
>> >
>> > I have tried to reproduce this issue on my system but could not
>> > reproduce
>> > it. PFA screen shorts explaining sql I got while creating and editing a
>> > template.
>> >
>> >>
>> >> - If a template is renamed, the treeview node is not updated.
>> >
>> > This is generic issue and needed to be resolved at higher level.
>>
>> No, I tested other nodes (database and sequence for example) and they
>> were properly updated. It's possible *some* are broken, but it's
>> certainly not a general issue.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [image/png] Screen Shot 2016-03-22 at 14.38.00.png (34.0K, 2-Screen%20Shot%202016-03-22%20at%2014.38.00.png)
  download | view image

  [image/png] Screen Shot 2016-03-22 at 14.37.53.png (41.5K, 3-Screen%20Shot%202016-03-22%20at%2014.37.53.png)
  download | view image

  [image/png] Screen Shot 2016-03-22 at 14.37.45.png (42.4K, 4-Screen%20Shot%202016-03-22%20at%2014.37.45.png)
  download | view image

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: PATCH: PGADMIN 4 - FTS templates node
  In-Reply-To: <CA+OCxoz1aNKF_WJ=yexAiCf-E7uVpWj9EeEFm9+FcOqDVRajng@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox