public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Sanket Mehta <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: PGADMIN 4 - FTS templates node
Date: Thu, 25 Feb 2016 14:07:00 +0000
Message-ID: <CA+OCxozUe1K9V-JF3HQ+Aj8gdEep8xhxD-GxrdkUB_k11eu55w@mail.gmail.com> (raw)
In-Reply-To: <CA+yw=mNfEV51SFb6h1nb23mFD94D0HqRDyMqYE5XwuSy8DOvug@mail.gmail.com>
References: <CA+yw=mMx=HsY2K01bQmdh6i+E4hUKJJM+KZWW_4B0AhB-O8cPw@mail.gmail.com>
<CA+yw=mNfEV51SFb6h1nb23mFD94D0HqRDyMqYE5XwuSy8DOvug@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi
On Tue, Feb 23, 2016 at 1:44 PM, Sanket Mehta <[email protected]
> wrote:
> Hi,
>
> PFA the revised patch for fts template node which includes dependency and
> dependent route handling code.
> Please do review it and if found proper please do commit it.
>
- When creating a new template, errors in the dialogue are not cleared -
e.g. the "Name must not be empty" doesn't clear, and save is not enabled,
even when a name is entered.
- "Fts Templates" should be "FTS Templates" on the treeview.
- The "Init" field should be labelled "Init Function"
- The "Lexize" field should be labelled "Lexize Function"
- Selecting a schema should be optional, with the default being the current
schema.
- 4 character indents are not consistently used in SQL templates
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (14+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: PGADMIN 4 - FTS templates node
In-Reply-To: <CA+OCxozUe1K9V-JF3HQ+Aj8gdEep8xhxD-GxrdkUB_k11eu55w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox