public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: Neel Patel <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] [Patch]: Foreign Table Module
Date: Tue, 10 May 2016 12:03:58 +0100
Message-ID: <CA+OCxoz26u=CXOHzZkS=x_nTBjQFRzhUa3Yhb0J1hqhutxV_ow@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmozo8+OFaYXx_GX81Y2ow=y=3EEuzb=w9coRJAEZbZ3cGw@mail.gmail.com>
References: <CAFOhELeqEBG3qd+Fe8nLfpc1SuJpkJzuzPmy1-jogD0220WiLw@mail.gmail.com>
	<CAFOhELfm9y9jQLLzvnQpKey5TX=yZkL+qaF=6g+CsvuWKFDh2w@mail.gmail.com>
	<CAFOhELekGKVKaMQt9L_itJw2WGdG69yVdiJDfq=1BPz3OjRJiw@mail.gmail.com>
	<CACCA4P0Q_9DBt43asNze9OjkJ+xya_m_cmf3DMoZB3HKWLKidw@mail.gmail.com>
	<CAFOhELf010FXe8_1AsBcc_GxrLYD5QzpQft+URS6zwf=pxtCiA@mail.gmail.com>
	<[email protected]>
	<CAFOhELeXyKfYoR4TAA2h8XErhQ7f1X9xkykpmN+Q4C52WMkG=Q@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAFOhELfqvoDVTJG7SE6aWnA-itzCUg91xWMknTin7NDfkRGHkA@mail.gmail.com>
	<CAG7mmozo8+OFaYXx_GX81Y2ow=y=3EEuzb=w9coRJAEZbZ3cGw@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

On Mon, May 9, 2016 at 1:23 PM, Ashesh Vashi <[email protected]>
wrote:

> On Mon, May 9, 2016 at 5:50 PM, Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch for the Foreign Tables module.
>>
>
Feedback from my initial testing:

- Owner is missing from the New dialogue.

- The Properties list shows "Select from the list" in a combo box for Owner
and
  Inherits.

- s/Oid/OID

- s/Foreign Server/Foreign server

- SQL Help filenames are not defined.

- SQL formatting is weird, e.g.

CREATE FOREIGN TABLE public.redis_table
(id text NOT NULL COLLATE pg_catalog."default",
value text NULL COLLATE pg_catalog."default")
    SERVER redis_server1
    OPTIONS (database '0');

instead of:

CREATE FOREIGN TABLE public.redis_table (
    id text NOT NULL COLLATE pg_catalog."default",
    value text NULL COLLATE pg_catalog."default"
)
    SERVER redis_server1
    OPTIONS (database '0');

- In the validation error messages, please replace ! with . and "can not"
with
  "cannot" for consistency with recently reviewed strings.

- s/mulitple/multiple (in the js).

- How do I manage the ACL?

Thanks.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (21+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4] [Patch]: Foreign Table Module
  In-Reply-To: <CA+OCxoz26u=CXOHzZkS=x_nTBjQFRzhUa3Yhb0J1hqhutxV_ow@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox