public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Anil Sahoo <[email protected]>
Cc: [email protected]
Subject: Re: Regarding feature #6841
Date: Fri, 19 Apr 2024 13:51:57 +0100
Message-ID: <CA+OCxoz30kYxbska9TFHDKO3kXoervwY6OYE2kcY6b-k6-iYvg@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_=tRn_zM6C8Pm6B5w6du8BjdtrRnb1XxX1qyEcaSx4kEg@mail.gmail.com>
References: <CAO+oWtBxAaDxdPOkcf=bTU0D6sDogX_az4SgN-5zKZt-9G=2xQ@mail.gmail.com>
<CA+OCxozieNmgfoGFq0G0Mxy+bu2Ct6hK9goZA3xtVJm9EaK6HA@mail.gmail.com>
<CAO+oWtA13KM+jmWm+MkGbmLps2dh3B06mEZu6-PQjZ0ip7+G6g@mail.gmail.com>
<CA+OCxoxMdX9Lsyugx7=_CZ3Z6K9jxHVTOBu4q=5_1cwgXsP7LQ@mail.gmail.com>
<CAM9w-_mdXSmj2xv9W2k6hdmdY+3V8rfi4gnjBA_Jy28ZYkza2Q@mail.gmail.com>
<CA+OCxozSdrD1ziKmfd_xLh72P031vdEo60wZxniyYP9sBLoM7Q@mail.gmail.com>
<CAM9w-_=tRn_zM6C8Pm6B5w6du8BjdtrRnb1XxX1qyEcaSx4kEg@mail.gmail.com>
Hi
On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal <
[email protected]> wrote:
>
>> Even if you put the cursor on the "SELECT"? If so, that would imply the
>> parser understands the string quoting; e.g. in this case, the Python
>> multiline string. Presumably then it would also understand regular single
>> and double quotes - what about (for example) a heredoc in a pl/sh function?
>>
> Yes, the parser understands all the aspects of a SQL query and so it
> understands what type of token the cursor is based on which it does the
> syntax highlighting I believe.
>
Does it? Even EPAS extensions?
>
>> It sounds like Thom has similar concerns, and I know him well enough to
>> know he wouldn't chime in without good reason.
>>
> There are limitations and it won't work correctly apart from standard SQL
> queries. Like I said, we're adding it as a new button without touching the
> existing working. If a user chooses to use the new button, he knows that
> pgAdmin will try to find the query on its own. This is an optional feature.
> Additionally, what we could do is when the user hits the button we will
> show a warning and the user can opt for not showing it again.
>
Ten minutes later they will have forgotten that warning.
I'm currently thinking that we should display the current query all the
time somehow (though I'm not sure how, without taking up a lot of space).
BTW, if we do figure out a way of doing this that we all agree is safe, I'm
going to want to see a bunch of automated tests against valid EPAS and PG
queries, as weird and bizarre as we can think of.
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Regarding feature #6841
In-Reply-To: <CA+OCxoz30kYxbska9TFHDKO3kXoervwY6OYE2kcY6b-k6-iYvg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox