public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working
Date: Tue, 22 Jan 2019 11:57:18 +0000
Message-ID: <CA+OCxoz52Gfzt_pAD8dAPTr5X+NtJA87FSgO2M90WAb__eS9Lw@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mZ6auyK+QkvU-Ti+QW-yytMXU5Mq0gz_Ld9PpPxOvTGA@mail.gmail.com>
References: <CAM9w-_m7Z8tj4VFySfyqj1F+ZEAgd4dnYTjTND4jY8YQEwXovQ@mail.gmail.com>
<CANxoLDciA484H5RMwbL3Nn+PudGFYxa_jjRnQnXsmYoPeOKxQw@mail.gmail.com>
<CA+OCxoygmKZnqhr-J9FmW0BaNgpB3T1Yr+j0OC46GDLXu2yGnw@mail.gmail.com>
<CAM9w-_mZ6auyK+QkvU-Ti+QW-yytMXU5Mq0gz_Ld9PpPxOvTGA@mail.gmail.com>
On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal
<[email protected]> wrote:
>
> Any suggestions on preferences name/desc ?
Name: "Confirm on close"
Desc: "Confirm closure of the browser or browser tab is intended
before proceeding."
> On Tue, Jan 22, 2019 at 3:01 PM Dave Page <[email protected]> wrote:
>>
>> Hi
>>
>> On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi
>> <[email protected]> wrote:
>> >
>> > Hi Aditya
>> >
>> > Below are my review comments:
>> >
>> > You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE" to make this request configurable, should it be the part of preferences setting instead of configuration? @Dave can you please comment on this.
>>
>> That does seem like something that should be a per-user preference,
>> not a global config option.
>>
>> > Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not clear as users perspective, can you please change it to some meaningful name.
>> >
>> > Apart from that code looks good to me.
>> >
>> > On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal <[email protected]> wrote:
>> >>
>> >> Hi Hackers,
>> >>
>> >> Attached is the patch to throw alert warning when user reloads or closes the browser.
>> >>
>> >> Kindly review.
>> >>
>> >> --
>> >> Thanks and Regards,
>> >> Aditya Toshniwal
>> >> Software Engineer | EnterpriseDB Software Solutions | Pune
>> >> "Don't Complain about Heat, Plant a tree"
>> >
>> >
>> >
>> > --
>> > Akshay Joshi
>> > Sr. Software Architect
>> >
>> >
>> > Phone: +91 20-3058-9517
>> > Mobile: +91 976-788-8246
>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working
In-Reply-To: <CA+OCxoz52Gfzt_pAD8dAPTr5X+NtJA87FSgO2M90WAb__eS9Lw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox