public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3319] Fix the cancel query button glitch in query tool
Date: Mon, 2 Jul 2018 15:37:11 +0100
Message-ID: <CA+OCxoz5Y4ewrtViKBimJrWCjCThvnpzctFVUfMQSJoMYtKCTA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZSjLmQk-T38TdC13uOmpibBTPFr6qk643wgMEW5r26y_w@mail.gmail.com>
References: <CAKKotZSjLmQk-T38TdC13uOmpibBTPFr6qk643wgMEW5r26y_w@mail.gmail.com>

Thanks, patch applied.

On Mon, Jul 2, 2018 at 5:58 AM, Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> PFA patch to fix the issue where cancel button remains enabled even after
> the query execution completes, I have moved the enable/disable logic for
> that button with rest of the buttons in '*disable_tool_buttons*' method &
> removed tests which are not required as we are already testing '
> *disable_tool_buttons*' method.
>
> *I had to fix it coz it was annoying me :)*
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#3319] Fix the cancel query button glitch in query tool
  In-Reply-To: <CA+OCxoz5Y4ewrtViKBimJrWCjCThvnpzctFVUfMQSJoMYtKCTA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox