public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3175] Fix PEP-8 issues
Date: Wed, 7 Mar 2018 11:48:01 +0000
Message-ID: <CA+OCxoz5trs52yspwsu0uO0NB_UXy20VrSTLf-maMHo5fwskFA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZRb8UJkbMui+Zd1K8cp2J-KoGEvkpFbC1WpFRWfhS9j=w@mail.gmail.com>
References: <CAKKotZQQecSw7Og3yXn8rK9yY_qKCmhb-Dj4Q2t9GDyRc9_D_w@mail.gmail.com>
<CAE+jjanM6exPkvYs+ECg4n1CD55Gs8_TiMzGycacvoTcnkSpJw@mail.gmail.com>
<CAKKotZRb8UJkbMui+Zd1K8cp2J-KoGEvkpFbC1WpFRWfhS9j=w@mail.gmail.com>
Thanks, applied!
On Mon, Mar 5, 2018 at 4:23 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Thanks Joao for reviewing.
>
>
> On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira <
> [email protected]> wrote:
>
>> Hi Murtuza,
>>
>> Looks good, and all tests are green. I run the commands provided and
>> nothing pops up.
>>
>> Only missing 374 :D
>>
> :-)
>
>
>>
>> Thanks
>> Joao
>>
>> On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix PEP8 issues in Browser & Database modules,
>>> pycodestyle --config=.pycodestyle pgadmin/browser/__init__.py
>>> pycodestyle --config=.pycodestyle pgadmin/browser/tests/
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/__init__.py
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/tests/
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (8+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][RM#3175] Fix PEP-8 issues
In-Reply-To: <CA+OCxoz5trs52yspwsu0uO0NB_UXy20VrSTLf-maMHo5fwskFA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox