public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM2653] Lock layout
Date: Fri, 31 May 2019 11:51:56 -0400
Message-ID: <CA+OCxoz7bcqNWzscTcfMaGt8LZYEJ4UNwq3zQu9_befQQOhv1g@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_nhVexMrK82cY+SS8vqMZn7CeN7=R5qz8vNkLHm+wdu1Q@mail.gmail.com>
References: <CAM9w-_n-1EKo44GctmEKy=SFRVK04a6yKGoQnawCq47X1FX=eA@mail.gmail.com>
	<CA+OCxowYcuidRHNSos7m7GFEK8LiPfKcD3YPwLbZmnaevdiBtg@mail.gmail.com>
	<CAM9w-_nhVexMrK82cY+SS8vqMZn7CeN7=R5qz8vNkLHm+wdu1Q@mail.gmail.com>

Thanks, patch applied.

On Fri, May 31, 2019 at 1:07 AM Aditya Toshniwal <
[email protected]> wrote:

> Hi,
>
> Attached is the updated rebased patch.
> I realised I didn't update the documentations. The patch also include doc
> updates.
>
> On Fri, May 31, 2019 at 12:42 AM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Can you rebase please?
>>
>> (pgadmin4) dpage@orac:*~/git/pgadmin4*$ git apply
>> ~/Downloads/RM2653.patch
>>
>> error: patch failed: web/pgadmin/browser/static/js/browser.js:15
>>
>> error: web/pgadmin/browser/static/js/browser.js: patch does not apply
>>
>> On Thu, May 30, 2019 at 6:15 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to introduce feature to lock the layout with three
>>> different levels:
>>> 1) None - No locking
>>> 2) Prevent docking - The docking/undocking of panels will be disabled
>>> 3) Full lock - The resizing along with docking/undocking of panels will
>>> be disabled
>>>
>>> - This can be changed from new menu under File->Lock layout-><The level>
>>> or from Preferences->Browser->Display->Lock Layout
>>> - JS test cases added.
>>>
>>> With this patch I have also changed below:
>>> 1) Moved the maintenance dialog button group control to new common
>>> control named RadioModern, which I have re-used in preferences for lock
>>> layout levels.
>>> 2) Added main nav bar menu with check feature, the menus which can
>>> checked.
>>> 3) Ability to add submenus from existing get_own_menuitems in python
>>> code which is not possible currently.
>>> 3) Separated all the layout related functions from browser.js to new
>>> file layout.js to help JS testing.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM2653] Lock layout
  In-Reply-To: <CA+OCxoz7bcqNWzscTcfMaGt8LZYEJ4UNwq3zQu9_befQQOhv1g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox