public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Huang, Jun <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Is there a mistake in line 22 of Make.bat?
Date: Thu, 14 Jan 2021 09:14:43 +0000
Message-ID: <CA+OCxozHHs4rDiD05GWLOjzd00h=9z3VZpX7M0eH==ap=b84YQ@mail.gmail.com> (raw)
In-Reply-To: <3e6e541367894c4c95ac17f8050aad96@G08CNEXMBPEKD06.g08.fujitsu.local>
References: <3e6e541367894c4c95ac17f8050aad96@G08CNEXMBPEKD06.g08.fujitsu.local>
Hi
On Thu, Jan 14, 2021 at 1:20 AM Huang, Jun <[email protected]>
wrote:
> Hi,
>
> The following code is line 22 of Make.bat:
> if "%Platform%" == "X86" (
>
> I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the
> result is "x86"(not "X86").
> If it's a mistake, the attached patch adds the changes.
>
Hmm, on the 32bit build VM I get this:
C:\Program Files (x86)\Microsoft Visual C++ Build Tools>echo %Platform%
X86
C:\Program Files (x86)\Microsoft Visual C++ Build Tools>
Which explains why everything works in the production builds. Note that
that system is VS 2015 though, but the 64 bit builds are VS 2017 iirc.
Given that 32 bit Windows builds will be dropped soon, I'm inclined to
leave this as-is for now.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Is there a mistake in line 22 of Make.bat?
In-Reply-To: <CA+OCxozHHs4rDiD05GWLOjzd00h=9z3VZpX7M0eH==ap=b84YQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox