public inbox for [email protected]help / color / mirror / Atom feed
Explain details popover changes proposal 11+ messages / 3 participants [nested] [flat]
* Explain details popover changes proposal @ 2021-01-08 07:06 Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Aditya Toshniwal @ 2021-01-08 07:06 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, I'm working on https://redmine.postgresql.org/issues/5488 and as per the discussion, we'll remove the current tooltip way for showing the details. Instead, we'll add some popover/panel upon clicking a node which will stay until closed. Below is the screenshot of partial implementation. Please confirm if I can proceed with full implementation. [image: Screenshot 2021-01-08 at 12.31.06 PM.png] -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-08 08:36 Ashesh Vashi <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Ashesh Vashi @ 2021-01-08 08:36 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < [email protected]> wrote: > Hi Hackers, > > I'm working on https://redmine.postgresql.org/issues/5488 and as per the > discussion, we'll remove the current tooltip way for showing the details. > Instead, we'll add some popover/panel upon clicking a node which will stay > until closed. > Below is the screenshot of partial implementation. > I like the idea of showing details in the pop up. We also need to think about the details in the SVG file downloaded. -- Ashesh > Please confirm if I can proceed with full implementation. > > [image: Screenshot 2021-01-08 at 12.31.06 PM.png] > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > <http://edbpostgres.com; > "Don't Complain about Heat, Plant a TREE" > Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-08 09:13 Dave Page <[email protected]> parent: Ashesh Vashi <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Dave Page @ 2021-01-08 09:13 UTC (permalink / raw) To: Ashesh Vashi <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers Hi On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi <[email protected]> wrote: > On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Hackers, >> >> I'm working on https://redmine.postgresql.org/issues/5488 and as per the >> discussion, we'll remove the current tooltip way for showing the details. >> Instead, we'll add some popover/panel upon clicking a node which will stay >> until closed. >> Below is the screenshot of partial implementation. >> > I like the idea of showing details in the pop up. > I agree, though I think the presentation could use some work to make the table-like layout a little cleaner (maybe alternating row shading or subtle cell borders or something). Perhaps check with Aradhana or Chethana for ideas? > We also need to think about the details in the SVG file downloaded. > We ignore the popups entirely at the moment don't we? It would be good to render any that are open though. > > -- Ashesh > > >> Please confirm if I can proceed with full implementation. >> >> [image: Screenshot 2021-01-08 at 12.31.06 PM.png] >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> <http://edbpostgres.com; >> "Don't Complain about Heat, Plant a TREE" >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-08 09:16 Ashesh Vashi <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Ashesh Vashi @ 2021-01-08 09:16 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers On Fri, 8 Jan 2021 at 14:43, Dave Page <[email protected]> wrote: > Hi > > On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi <[email protected]> > wrote: > >> On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> I'm working on https://redmine.postgresql.org/issues/5488 and as per >>> the discussion, we'll remove the current tooltip way for showing the >>> details. Instead, we'll add some popover/panel upon clicking a node >>> which will stay until closed. >>> Below is the screenshot of partial implementation. >>> >> I like the idea of showing details in the pop up. >> > > I agree, though I think the presentation could use some work to make the > table-like layout a little cleaner (maybe alternating row shading or subtle > cell borders or something). Perhaps check with Aradhana or Chethana for > ideas? > > >> We also need to think about the details in the SVG file downloaded. >> > > We ignore the popups entirely at the moment don't we? It would be good to > render any that are open though. > We have put details in the title attribute, hence - it should be visible as cluttered text on hover. (Assumption - I have not tried). — Ashesh > > > >> >> -- Ashesh >> >> >>> Please confirm if I can proceed with full implementation. >>> >>> [image: Screenshot 2021-01-08 at 12.31.06 PM.png] >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> <http://edbpostgres.com; >>> "Don't Complain about Heat, Plant a TREE" >>> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com; *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi; Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-08 09:22 Dave Page <[email protected]> parent: Ashesh Vashi <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Dave Page @ 2021-01-08 09:22 UTC (permalink / raw) To: Ashesh Vashi <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers On Fri, Jan 8, 2021 at 9:17 AM Ashesh Vashi <[email protected]> wrote: > > > On Fri, 8 Jan 2021 at 14:43, Dave Page <[email protected]> wrote: > >> Hi >> >> On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi < >> [email protected]> wrote: >> >>> On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < >>> [email protected]> wrote: >>> >>>> Hi Hackers, >>>> >>>> I'm working on https://redmine.postgresql.org/issues/5488 and as per >>>> the discussion, we'll remove the current tooltip way for showing the >>>> details. Instead, we'll add some popover/panel upon clicking a node >>>> which will stay until closed. >>>> Below is the screenshot of partial implementation. >>>> >>> I like the idea of showing details in the pop up. >>> >> >> I agree, though I think the presentation could use some work to make the >> table-like layout a little cleaner (maybe alternating row shading or subtle >> cell borders or something). Perhaps check with Aradhana or Chethana for >> ideas? >> >> >>> We also need to think about the details in the SVG file downloaded. >>> >> >> We ignore the popups entirely at the moment don't we? It would be good to >> render any that are open though. >> > > We have put details in the title attribute, hence - it should be visible > as cluttered text on hover. (Assumption - I have not tried). > OK, well it seems reasonable to continue to do that for all nodes. However, maybe we should also render any popups that are open at time of download - that way, printing or converting to a raster format will still display those popups. > > — Ashesh > >> >> >> >>> >>> -- Ashesh >>> >>> >>>> Please confirm if I can proceed with full implementation. >>>> >>>> [image: Screenshot 2021-01-08 at 12.31.06 PM.png] >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> <http://edbpostgres.com; >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> -- > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com; > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi; > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-08 10:46 Aditya Toshniwal <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Aditya Toshniwal @ 2021-01-08 10:46 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers Hi, On Fri, Jan 8, 2021 at 2:53 PM Dave Page <[email protected]> wrote: > > > On Fri, Jan 8, 2021 at 9:17 AM Ashesh Vashi <[email protected]> > wrote: > >> >> >> On Fri, 8 Jan 2021 at 14:43, Dave Page <[email protected]> wrote: >> >>> Hi >>> >>> On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi < >>> [email protected]> wrote: >>> >>>> On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < >>>> [email protected]> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> I'm working on https://redmine.postgresql.org/issues/5488 and as per >>>>> the discussion, we'll remove the current tooltip way for showing the >>>>> details. Instead, we'll add some popover/panel upon clicking a node >>>>> which will stay until closed. >>>>> Below is the screenshot of partial implementation. >>>>> >>>> I like the idea of showing details in the pop up. >>>> >>> >>> I agree, though I think the presentation could use some work to make the >>> table-like layout a little cleaner (maybe alternating row shading or subtle >>> cell borders or something). Perhaps check with Aradhana or Chethana for >>> ideas? >>> >> Yes. > >>> >>>> We also need to think about the details in the SVG file downloaded. >>>> >>> >>> We ignore the popups entirely at the moment don't we? It would be good >>> to render any that are open though. >>> >> >> We have put details in the title attribute, hence - it should be visible >> as cluttered text on hover. (Assumption - I have not tried). >> > > OK, well it seems reasonable to continue to do that for all nodes. > However, maybe we should also render any popups that are open at time of > download - that way, printing or converting to a raster format will still > display those popups. > With the new changes, the SVG tooltip will be removed completely. The new pop up is HTML based and floats above the diagram. I mean, if you zoom in/out the plan, it does not affect the popup. I'm thinking to append all the tables to the download SVG and add click events on the nodes which will scroll to that table. This is just a thought, not sure if it will work. But that would be a separate task. > > >> >> — Ashesh >> >>> >>> >>> >>>> >>>> -- Ashesh >>>> >>>> >>>>> Please confirm if I can proceed with full implementation. >>>>> >>>>> [image: Screenshot 2021-01-08 at 12.31.06 PM.png] >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>> <http://edbpostgres.com; >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: http://www.enterprisedb.com >>> >>> -- >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> <http://www.enterprisedb.com; >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi; >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-08 11:00 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Dave Page @ 2021-01-08 11:00 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers On Fri, Jan 8, 2021 at 10:46 AM Aditya Toshniwal < [email protected]> wrote: > Hi, > > > On Fri, Jan 8, 2021 at 2:53 PM Dave Page <[email protected]> wrote: > >> >> >> On Fri, Jan 8, 2021 at 9:17 AM Ashesh Vashi < >> [email protected]> wrote: >> >>> >>> >>> On Fri, 8 Jan 2021 at 14:43, Dave Page <[email protected]> wrote: >>> >>>> Hi >>>> >>>> On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi < >>>> [email protected]> wrote: >>>> >>>>> On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> I'm working on https://redmine.postgresql.org/issues/5488 and as per >>>>>> the discussion, we'll remove the current tooltip way for showing the >>>>>> details. Instead, we'll add some popover/panel upon clicking a node >>>>>> which will stay until closed. >>>>>> Below is the screenshot of partial implementation. >>>>>> >>>>> I like the idea of showing details in the pop up. >>>>> >>>> >>>> I agree, though I think the presentation could use some work to make >>>> the table-like layout a little cleaner (maybe alternating row shading or >>>> subtle cell borders or something). Perhaps check with Aradhana or Chethana >>>> for ideas? >>>> >>> Yes. > >> >>>> >>>>> We also need to think about the details in the SVG file downloaded. >>>>> >>>> >>>> We ignore the popups entirely at the moment don't we? It would be good >>>> to render any that are open though. >>>> >>> >>> We have put details in the title attribute, hence - it should be visible >>> as cluttered text on hover. (Assumption - I have not tried). >>> >> >> OK, well it seems reasonable to continue to do that for all nodes. >> However, maybe we should also render any popups that are open at time of >> download - that way, printing or converting to a raster format will still >> display those popups. >> > With the new changes, the SVG tooltip will be removed completely. The new > pop up is HTML based and floats above the diagram. I mean, if you zoom > in/out the plan, it does not affect the popup. > I'm thinking to append all the tables to the download SVG and add click > events on the nodes which will scroll to that table. This is just a > thought, not sure if it will work. But that would be a separate task. > We certainly shouldn't remove functionality that works now, without replacing it with something at least as good. I think this is relatively low priority though - can't we just fix the basic problem, or is that caused by the SVG tooltips, whose location is out of our control? > >> >>> >>> — Ashesh >>> >>>> >>>> >>>> >>>>> >>>>> -- Ashesh >>>>> >>>>> >>>>>> Please confirm if I can proceed with full implementation. >>>>>> >>>>>> [image: Screenshot 2021-01-08 at 12.31.06 PM.png] >>>>>> >>>>>> -- >>>>>> Thanks, >>>>>> Aditya Toshniwal >>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>> <http://edbpostgres.com; >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EDB: http://www.enterprisedb.com >>>> >>>> -- >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> <http://www.enterprisedb.com; >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> <http://www.linkedin.com/in/asheshvashi; >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > <http://edbpostgres.com; > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-08 11:37 Aditya Toshniwal <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Aditya Toshniwal @ 2021-01-08 11:37 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers Hi, On Fri, Jan 8, 2021 at 4:30 PM Dave Page <[email protected]> wrote: > > > On Fri, Jan 8, 2021 at 10:46 AM Aditya Toshniwal < > [email protected]> wrote: > >> Hi, >> >> >> On Fri, Jan 8, 2021 at 2:53 PM Dave Page <[email protected]> wrote: >> >>> >>> >>> On Fri, Jan 8, 2021 at 9:17 AM Ashesh Vashi < >>> [email protected]> wrote: >>> >>>> >>>> >>>> On Fri, 8 Jan 2021 at 14:43, Dave Page <[email protected]> wrote: >>>> >>>>> Hi >>>>> >>>>> On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi < >>>>> [email protected]> wrote: >>>>> >>>>>> On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> I'm working on https://redmine.postgresql.org/issues/5488 and as >>>>>>> per the discussion, we'll remove the current tooltip way for showing the >>>>>>> details. Instead, we'll add some popover/panel upon clicking a node >>>>>>> which will stay until closed. >>>>>>> Below is the screenshot of partial implementation. >>>>>>> >>>>>> I like the idea of showing details in the pop up. >>>>>> >>>>> >>>>> I agree, though I think the presentation could use some work to make >>>>> the table-like layout a little cleaner (maybe alternating row shading or >>>>> subtle cell borders or something). Perhaps check with Aradhana or Chethana >>>>> for ideas? >>>>> >>>> Yes. >> >>> >>>>> >>>>>> We also need to think about the details in the SVG file downloaded. >>>>>> >>>>> >>>>> We ignore the popups entirely at the moment don't we? It would be good >>>>> to render any that are open though. >>>>> >>>> >>>> We have put details in the title attribute, hence - it should be >>>> visible as cluttered text on hover. (Assumption - I have not tried). >>>> >>> >>> OK, well it seems reasonable to continue to do that for all nodes. >>> However, maybe we should also render any popups that are open at time of >>> download - that way, printing or converting to a raster format will still >>> display those popups. >>> >> With the new changes, the SVG tooltip will be removed completely. The new >> pop up is HTML based and floats above the diagram. I mean, if you zoom >> in/out the plan, it does not affect the popup. >> I'm thinking to append all the tables to the download SVG and add click >> events on the nodes which will scroll to that table. This is just a >> thought, not sure if it will work. But that would be a separate task. >> > > We certainly shouldn't remove functionality that works now, without > replacing it with something at least as good. > > I think this is relatively low priority though - can't we just fix the > basic problem, or is that caused by the SVG tooltips, whose location is out > of our control? > Currently toolips appear only on hover, and if they are large then there is no way to see them completely. In the past, there have been attempts to fix it but still it causes issues. Correcting my previous comment, it's a html tooltip and not a SVG tooltip. With the new changes, multiple issues are fixed together - tooltip will not go out of screen, user can see full details, UX improved. > > >> >>> >>>> >>>> — Ashesh >>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> -- Ashesh >>>>>> >>>>>> >>>>>>> Please confirm if I can proceed with full implementation. >>>>>>> >>>>>>> [image: Screenshot 2021-01-08 at 12.31.06 PM.png] >>>>>>> >>>>>>> -- >>>>>>> Thanks, >>>>>>> Aditya Toshniwal >>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>> <http://edbpostgres.com; >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EDB: http://www.enterprisedb.com >>>>> >>>>> -- >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> <http://www.enterprisedb.com; >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> <http://www.linkedin.com/in/asheshvashi; >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: http://www.enterprisedb.com >>> >>> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> <http://edbpostgres.com; >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-08 15:34 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Dave Page @ 2021-01-08 15:34 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers On Fri, Jan 8, 2021 at 11:38 AM Aditya Toshniwal < [email protected]> wrote: > Hi, > > On Fri, Jan 8, 2021 at 4:30 PM Dave Page <[email protected]> wrote: > >> >> >> On Fri, Jan 8, 2021 at 10:46 AM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi, >>> >>> >>> On Fri, Jan 8, 2021 at 2:53 PM Dave Page <[email protected]> wrote: >>> >>>> >>>> >>>> On Fri, Jan 8, 2021 at 9:17 AM Ashesh Vashi < >>>> [email protected]> wrote: >>>> >>>>> >>>>> >>>>> On Fri, 8 Jan 2021 at 14:43, Dave Page <[email protected]> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi Hackers, >>>>>>>> >>>>>>>> I'm working on https://redmine.postgresql.org/issues/5488 and as >>>>>>>> per the discussion, we'll remove the current tooltip way for showing the >>>>>>>> details. Instead, we'll add some popover/panel upon clicking a node >>>>>>>> which will stay until closed. >>>>>>>> Below is the screenshot of partial implementation. >>>>>>>> >>>>>>> I like the idea of showing details in the pop up. >>>>>>> >>>>>> >>>>>> I agree, though I think the presentation could use some work to make >>>>>> the table-like layout a little cleaner (maybe alternating row shading or >>>>>> subtle cell borders or something). Perhaps check with Aradhana or Chethana >>>>>> for ideas? >>>>>> >>>>> Yes. >>> >>>> >>>>>> >>>>>>> We also need to think about the details in the SVG file downloaded. >>>>>>> >>>>>> >>>>>> We ignore the popups entirely at the moment don't we? It would be >>>>>> good to render any that are open though. >>>>>> >>>>> >>>>> We have put details in the title attribute, hence - it should be >>>>> visible as cluttered text on hover. (Assumption - I have not tried). >>>>> >>>> >>>> OK, well it seems reasonable to continue to do that for all nodes. >>>> However, maybe we should also render any popups that are open at time of >>>> download - that way, printing or converting to a raster format will still >>>> display those popups. >>>> >>> With the new changes, the SVG tooltip will be removed completely. The >>> new pop up is HTML based and floats above the diagram. I mean, if you zoom >>> in/out the plan, it does not affect the popup. >>> I'm thinking to append all the tables to the download SVG and add click >>> events on the nodes which will scroll to that table. This is just a >>> thought, not sure if it will work. But that would be a separate task. >>> >> >> We certainly shouldn't remove functionality that works now, without >> replacing it with something at least as good. >> > >> I think this is relatively low priority though - can't we just fix the >> basic problem, or is that caused by the SVG tooltips, whose location is out >> of our control? >> > Currently toolips appear only on hover, and if they are large then there > is no way to see them completely. In the past, there have been attempts to > fix it but still it causes issues. Correcting my previous comment, it's a > html tooltip and not a SVG tooltip. > With the new changes, multiple issues are fixed together - tooltip will > not go out of screen, user can see full details, UX improved. > Sure, the main UI would definitely be improved. I just want to make sure we don't negatively impact the download version. > > >> >> >>> >>>> >>>>> >>>>> — Ashesh >>>>> >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> -- Ashesh >>>>>>> >>>>>>> >>>>>>>> Please confirm if I can proceed with full implementation. >>>>>>>> >>>>>>>> [image: Screenshot 2021-01-08 at 12.31.06 PM.png] >>>>>>>> >>>>>>>> -- >>>>>>>> Thanks, >>>>>>>> Aditya Toshniwal >>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>> <http://edbpostgres.com; >>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EDB: http://www.enterprisedb.com >>>>>> >>>>>> -- >>>>> >>>>> -- >>>>> >>>>> Thanks & Regards, >>>>> >>>>> Ashesh Vashi >>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>> <http://www.enterprisedb.com; >>>>> >>>>> >>>>> *http://www.linkedin.com/in/asheshvashi* >>>>> <http://www.linkedin.com/in/asheshvashi; >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EDB: http://www.enterprisedb.com >>>> >>>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> <http://edbpostgres.com; >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > <http://edbpostgres.com; > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-11 05:24 Aditya Toshniwal <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Aditya Toshniwal @ 2021-01-11 05:24 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers Hi Dave, On Fri, Jan 8, 2021 at 9:04 PM Dave Page <[email protected]> wrote: > > > On Fri, Jan 8, 2021 at 11:38 AM Aditya Toshniwal < > [email protected]> wrote: > >> Hi, >> >> On Fri, Jan 8, 2021 at 4:30 PM Dave Page <[email protected]> wrote: >> >>> >>> >>> On Fri, Jan 8, 2021 at 10:46 AM Aditya Toshniwal < >>> [email protected]> wrote: >>> >>>> Hi, >>>> >>>> >>>> On Fri, Jan 8, 2021 at 2:53 PM Dave Page <[email protected]> wrote: >>>> >>>>> >>>>> >>>>> On Fri, Jan 8, 2021 at 9:17 AM Ashesh Vashi < >>>>> [email protected]> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Fri, 8 Jan 2021 at 14:43, Dave Page <[email protected]> wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hi Hackers, >>>>>>>>> >>>>>>>>> I'm working on https://redmine.postgresql.org/issues/5488 and as >>>>>>>>> per the discussion, we'll remove the current tooltip way for showing the >>>>>>>>> details. Instead, we'll add some popover/panel upon clicking a node >>>>>>>>> which will stay until closed. >>>>>>>>> Below is the screenshot of partial implementation. >>>>>>>>> >>>>>>>> I like the idea of showing details in the pop up. >>>>>>>> >>>>>>> >>>>>>> I agree, though I think the presentation could use some work to make >>>>>>> the table-like layout a little cleaner (maybe alternating row shading or >>>>>>> subtle cell borders or something). Perhaps check with Aradhana or Chethana >>>>>>> for ideas? >>>>>>> >>>>>> Yes. >>>> >>>>> >>>>>>> >>>>>>>> We also need to think about the details in the SVG file downloaded. >>>>>>>> >>>>>>> >>>>>>> We ignore the popups entirely at the moment don't we? It would be >>>>>>> good to render any that are open though. >>>>>>> >>>>>> >>>>>> We have put details in the title attribute, hence - it should be >>>>>> visible as cluttered text on hover. (Assumption - I have not tried). >>>>>> >>>>> >>>>> OK, well it seems reasonable to continue to do that for all nodes. >>>>> However, maybe we should also render any popups that are open at time of >>>>> download - that way, printing or converting to a raster format will still >>>>> display those popups. >>>>> >>>> With the new changes, the SVG tooltip will be removed completely. The >>>> new pop up is HTML based and floats above the diagram. I mean, if you zoom >>>> in/out the plan, it does not affect the popup. >>>> I'm thinking to append all the tables to the download SVG and add click >>>> events on the nodes which will scroll to that table. This is just a >>>> thought, not sure if it will work. But that would be a separate task. >>>> >>> >>> We certainly shouldn't remove functionality that works now, without >>> replacing it with something at least as good. >>> >> >>> I think this is relatively low priority though - can't we just fix the >>> basic problem, or is that caused by the SVG tooltips, whose location is out >>> of our control? >>> >> Currently toolips appear only on hover, and if they are large then there >> is no way to see them completely. In the past, there have been attempts to >> fix it but still it causes issues. Correcting my previous comment, it's a >> html tooltip and not a SVG tooltip. >> With the new changes, multiple issues are fixed together - tooltip will >> not go out of screen, user can see full details, UX improved. >> > > Sure, the main UI would definitely be improved. I just want to make sure > we don't negatively impact the download version. > The download version will be as before. No change. > > >> >> >>> >>> >>>> >>>>> >>>>>> >>>>>> — Ashesh >>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> -- Ashesh >>>>>>>> >>>>>>>> >>>>>>>>> Please confirm if I can proceed with full implementation. >>>>>>>>> >>>>>>>>> [image: Screenshot 2021-01-08 at 12.31.06 PM.png] >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Thanks, >>>>>>>>> Aditya Toshniwal >>>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>>> <http://edbpostgres.com; >>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EDB: http://www.enterprisedb.com >>>>>>> >>>>>>> -- >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & Regards, >>>>>> >>>>>> Ashesh Vashi >>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>> <http://www.enterprisedb.com; >>>>>> >>>>>> >>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>> <http://www.linkedin.com/in/asheshvashi; >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EDB: http://www.enterprisedb.com >>>>> >>>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> <http://edbpostgres.com; >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: http://www.enterprisedb.com >>> >>> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> <http://edbpostgres.com; >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Explain details popover changes proposal @ 2021-01-11 09:06 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 11+ messages in thread From: Dave Page @ 2021-01-11 09:06 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers On Mon, Jan 11, 2021 at 5:24 AM Aditya Toshniwal < [email protected]> wrote: > Hi Dave, > > On Fri, Jan 8, 2021 at 9:04 PM Dave Page <[email protected]> wrote: > >> >> >> On Fri, Jan 8, 2021 at 11:38 AM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi, >>> >>> On Fri, Jan 8, 2021 at 4:30 PM Dave Page <[email protected]> wrote: >>> >>>> >>>> >>>> On Fri, Jan 8, 2021 at 10:46 AM Aditya Toshniwal < >>>> [email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> >>>>> On Fri, Jan 8, 2021 at 2:53 PM Dave Page <[email protected]> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Fri, Jan 8, 2021 at 9:17 AM Ashesh Vashi < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, 8 Jan 2021 at 14:43, Dave Page <[email protected]> wrote: >>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Hi Hackers, >>>>>>>>>> >>>>>>>>>> I'm working on https://redmine.postgresql.org/issues/5488 and as >>>>>>>>>> per the discussion, we'll remove the current tooltip way for showing the >>>>>>>>>> details. Instead, we'll add some popover/panel upon clicking a node >>>>>>>>>> which will stay until closed. >>>>>>>>>> Below is the screenshot of partial implementation. >>>>>>>>>> >>>>>>>>> I like the idea of showing details in the pop up. >>>>>>>>> >>>>>>>> >>>>>>>> I agree, though I think the presentation could use some work to >>>>>>>> make the table-like layout a little cleaner (maybe alternating row shading >>>>>>>> or subtle cell borders or something). Perhaps check with Aradhana or >>>>>>>> Chethana for ideas? >>>>>>>> >>>>>>> Yes. >>>>> >>>>>> >>>>>>>> >>>>>>>>> We also need to think about the details in the SVG file downloaded. >>>>>>>>> >>>>>>>> >>>>>>>> We ignore the popups entirely at the moment don't we? It would be >>>>>>>> good to render any that are open though. >>>>>>>> >>>>>>> >>>>>>> We have put details in the title attribute, hence - it should be >>>>>>> visible as cluttered text on hover. (Assumption - I have not tried). >>>>>>> >>>>>> >>>>>> OK, well it seems reasonable to continue to do that for all nodes. >>>>>> However, maybe we should also render any popups that are open at time of >>>>>> download - that way, printing or converting to a raster format will still >>>>>> display those popups. >>>>>> >>>>> With the new changes, the SVG tooltip will be removed completely. The >>>>> new pop up is HTML based and floats above the diagram. I mean, if you zoom >>>>> in/out the plan, it does not affect the popup. >>>>> I'm thinking to append all the tables to the download SVG and add >>>>> click events on the nodes which will scroll to that table. This is just a >>>>> thought, not sure if it will work. But that would be a separate task. >>>>> >>>> >>>> We certainly shouldn't remove functionality that works now, without >>>> replacing it with something at least as good. >>>> >>> >>>> I think this is relatively low priority though - can't we just fix the >>>> basic problem, or is that caused by the SVG tooltips, whose location is out >>>> of our control? >>>> >>> Currently toolips appear only on hover, and if they are large then there >>> is no way to see them completely. In the past, there have been attempts to >>> fix it but still it causes issues. Correcting my previous comment, it's a >>> html tooltip and not a SVG tooltip. >>> With the new changes, multiple issues are fixed together - tooltip will >>> not go out of screen, user can see full details, UX improved. >>> >> >> Sure, the main UI would definitely be improved. I just want to make sure >> we don't negatively impact the download version. >> > The download version will be as before. No change. > OK, that's fine. Thanks. > >> >>> >>> >>>> >>>> >>>>> >>>>>> >>>>>>> >>>>>>> — Ashesh >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> -- Ashesh >>>>>>>>> >>>>>>>>> >>>>>>>>>> Please confirm if I can proceed with full implementation. >>>>>>>>>> >>>>>>>>>> [image: Screenshot 2021-01-08 at 12.31.06 PM.png] >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Thanks, >>>>>>>>>> Aditya Toshniwal >>>>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>>>> <http://edbpostgres.com; >>>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EDB: http://www.enterprisedb.com >>>>>>>> >>>>>>>> -- >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> Ashesh Vashi >>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>> <http://www.enterprisedb.com; >>>>>>> >>>>>>> >>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>> <http://www.linkedin.com/in/asheshvashi; >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EDB: http://www.enterprisedb.com >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>> <http://edbpostgres.com; >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EDB: http://www.enterprisedb.com >>>> >>>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> <http://edbpostgres.com; >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > <http://edbpostgres.com; > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com Attachments: [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png) download | view image ^ permalink raw reply [nested|flat] 11+ messages in thread
end of thread, other threads:[~2021-01-11 09:06 UTC | newest] Thread overview: 11+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-01-08 07:06 Explain details popover changes proposal Aditya Toshniwal <[email protected]> 2021-01-08 08:36 ` Ashesh Vashi <[email protected]> 2021-01-08 09:13 ` Dave Page <[email protected]> 2021-01-08 09:16 ` Ashesh Vashi <[email protected]> 2021-01-08 09:22 ` Dave Page <[email protected]> 2021-01-08 10:46 ` Aditya Toshniwal <[email protected]> 2021-01-08 11:00 ` Dave Page <[email protected]> 2021-01-08 11:37 ` Aditya Toshniwal <[email protected]> 2021-01-08 15:34 ` Dave Page <[email protected]> 2021-01-11 05:24 ` Aditya Toshniwal <[email protected]> 2021-01-11 09:06 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox