public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAmin4][Patch] - Kerberos support for Windows Installer
Date: Thu, 21 Jan 2021 09:47:32 +0000
Message-ID: <CA+OCxozOnj+RFycxhmmni-mYXAn-Jw58bwWgXnFMqDkrXimSnQ@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELd8YNNq5Ot-qUD0QOP_Of=iKadaTrC9trJVLENttErGsg@mail.gmail.com>
References: <CAFOhELd8YNNq5Ot-qUD0QOP_Of=iKadaTrC9trJVLENttErGsg@mail.gmail.com>

Hi

On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find the attached patch to add the Kerberos support in the Windows
> installer script.
>

A couple of comments:

- The file names should be in lower case in the COPY lines. It will still
work of course, but for consistency and style...
- There's no check that the environment variable is set to a valid value.
For others, we have code block like:

IF NOT EXIST "%PGADMIN_QT_DIR%" (
    ECHO !PGADMIN_QT_DIR! does not exist.
    ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
    EXIT /B 1
)


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAmin4][Patch] - Kerberos support for Windows Installer
  In-Reply-To: <CA+OCxozOnj+RFycxhmmni-mYXAn-Jw58bwWgXnFMqDkrXimSnQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox