public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAmin4][Patch] - Kerberos support for Windows Installer
Date: Thu, 21 Jan 2021 16:29:33 +0530
Message-ID: <CANxoLDcimd7gC3oUE4fzFNwyDQESJ1Xw5hmn4iq_9ExWjU3RCg@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELfFzkwDBX22K3fsTg+6piPkimvXPw1JVejVauWTsCTt8Q@mail.gmail.com>
References: <CAFOhELd8YNNq5Ot-qUD0QOP_Of=iKadaTrC9trJVLENttErGsg@mail.gmail.com>
<CA+OCxozOnj+RFycxhmmni-mYXAn-Jw58bwWgXnFMqDkrXimSnQ@mail.gmail.com>
<CAFOhELfFzkwDBX22K3fsTg+6piPkimvXPw1JVejVauWTsCTt8Q@mail.gmail.com>
Thanks, patch applied.
On Thu, Jan 21, 2021 at 3:46 PM Khushboo Vashi <
[email protected]> wrote:
> Hi Dave,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushbo
>
> On Thu, Jan 21, 2021 at 3:17 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to add the Kerberos support in the
>>> Windows installer script.
>>>
>>
>> A couple of comments:
>>
>> - The file names should be in lower case in the COPY lines. It will still
>> work of course, but for consistency and style...
>>
> Fixed.
>
>> - There's no check that the environment variable is set to a valid value.
>> For others, we have code block like:
>>
>> Fixed.
>
>> IF NOT EXIST "%PGADMIN_QT_DIR%" (
>> ECHO !PGADMIN_QT_DIR! does not exist.
>> ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
>> EXIT /B 1
>> )
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAmin4][Patch] - Kerberos support for Windows Installer
In-Reply-To: <CANxoLDcimd7gC3oUE4fzFNwyDQESJ1Xw5hmn4iq_9ExWjU3RCg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox