public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Feature #5370 User should be able to set the binary path for each database server
Date: Fri, 21 May 2021 08:31:04 +0100
Message-ID: <CA+OCxozV34Ec_+VoxNfUL0ROdsuzmyqvo_wfosBUSw6OTssUGg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDf82r-kZfctPF5kG1dePwgCEveL=XGo7anmZi9Vvjdb=Q@mail.gmail.com>
References: <CANxoLDfRrBE4e0sFL7nt7GxRy4ALyjCMSwv_YC1RPq33uWBzwA@mail.gmail.com>
<CAM9w-_nYDWxCVOB6-xLu-Yqw79juoAKv1Jv7UJcSujphPK2hkg@mail.gmail.com>
<CANxoLDfe8H-E9qmO1KYiRVodpBRWPcEmxKKKwPXQ4MDShE9XPQ@mail.gmail.com>
<CA+OCxozFY0Vs_KmhmCR0ranY=ti-Qc5YU1vM1nPsj0erQDnWvQ@mail.gmail.com>
<CANxoLDeeYbPuZc4DPdsCMEEiPdwopM+cq0VOwsrahz1wvjZQNg@mail.gmail.com>
<CA+OCxozkNdeH3RmMm-wS_YLNScRn7fUqZ0zEf+p9MVeWR_u+tQ@mail.gmail.com>
<CANxoLDf82r-kZfctPF5kG1dePwgCEveL=XGo7anmZi9Vvjdb=Q@mail.gmail.com>
Hi Akshay,
On Fri, May 21, 2021 at 8:03 AM Akshay Joshi <[email protected]>
wrote:
> Hi Dave/Hackers
>
> As per your suggestion, I have created a new Backform control
> "BinaryPathsGridControl" and two new BackgridCell (BackgridRadioCell and
> BackgridSelectFileCell). Please refer to the screenshot below:
> [image: Binary_Path.png]
>
> Are the above changes look good to you? The radio button will only be
> enabled when there is a path. Added validate button which will validate the
> Utilities (pg_dump, pg_dumpall, ...)
>
Nice! Just a couple of comments:
- I assume the browse button is removed in server mode as discussed? Maybe
we should add a config.py option to allow that behaviour to be overridden
if the admin doesn't care about sandboxing?
- I think we need some hint text. How about something like:
Enter the directory in which the psql, pg_dump, pg_dumpall, and pg_restore
utilities can be found for the corresponding database server version. The
default path will be used for server versions that do not have a path
specified.
--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
Attachments:
[image/png] Binary_Path.png (323.2K, 3-Binary_Path.png)
download | view image
view thread (14+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Feature #5370 User should be able to set the binary path for each database server
In-Reply-To: <CA+OCxozV34Ec_+VoxNfUL0ROdsuzmyqvo_wfosBUSw6OTssUGg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox