public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM1739 - Don't show Upload File icon unless it is not in capabilities [Storage Manager]
Date: Fri, 7 Oct 2016 12:31:48 +0100
Message-ID: <CA+OCxozVi43RHwNkfcCutmaCwk-JmGw1XdeqqEWtU3wQA8AmuA@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D81MtwXQWCfx+EY7Qj5NPuSOb4g9XP8zOsy7MjsWA20Jg@mail.gmail.com>
References: <CAM5-9D81MtwXQWCfx+EY7Qj5NPuSOb4g9XP8zOsy7MjsWA20Jg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks, patch applied.

On Fri, Oct 7, 2016 at 7:03 AM, Surinder Kumar
<[email protected]> wrote:
> Hi,
>
> Issue:
> When clicked on upload icon while saving a file prompt user to leave page.
> It is because the icon is a button and its type is set to submit which makes
> it to prompt, instead it should be 'button'
>
> Storage Manager's menu items depends on capabilities list set by the module
> using it. If capabilities doesn't have 'upload' in it, It won't work. Upload
> button is bound to click event only when it is in capabilities.
>
> Solution:
> As upload button is being added only when it is in capabilities, so upload
> button html is removed from html file. It will not shown on UI untill it is
> in capabilities list.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM1739 - Don't show Upload File icon unless it is not in capabilities [Storage Manager]
  In-Reply-To: <CA+OCxozVi43RHwNkfcCutmaCwk-JmGw1XdeqqEWtU3wQA8AmuA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox