public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Chris Mayo <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [PATCH 1/2] Fix link to code_review in submitting_patches.rst
Date: Mon, 10 Oct 2016 09:33:34 +0100
Message-ID: <CA+OCxozdes15q2Hd0SBZOpax581uFYnRwUJiGwcP2YeU_oJqbA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks, patch applied.

BTW, please send any future patches as attachments rather than inline, as I
had to apply this manually as it got munged in the email body.

Thanks!

On Sunday, October 9, 2016, Chris Mayo <[email protected]> wrote:

> Signed-off-by: Chris Mayo <[email protected] <javascript:;>>
> ---
>  docs/en_US/submitting_patches.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_
> patches.rst
> index b4bbebe..9f8ab42 100644
> --- a/docs/en_US/submitting_patches.rst
> +++ b/docs/en_US/submitting_patches.rst
> @@ -29,7 +29,7 @@ might run::
>  to create a patch between your development branch and the public master
> branch.
>
>  Once you have your patch, check it thoroughly to ensure it meets the
> pgAdmin
> -:doc:`coding_standards`, and review it against the :doc:`code-review' to
> minimise
> +:doc:`coding_standards`, and review it against the :doc:`code_review` to
> minimise
>  the chances of it being rejected. Once you're happy with your work, mail
> it to the
>  `mailing list <mailto:[email protected] <javascript:;>>`.
> Please ensure you
>  include a full description of what the patch does, as well as the
> rationale for
> --
> 2.7.3
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected]
> <javascript:;>)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCH 1/2] Fix link to code_review in submitting_patches.rst
  In-Reply-To: <CA+OCxozdes15q2Hd0SBZOpax581uFYnRwUJiGwcP2YeU_oJqbA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox