public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Pramod Ahire <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Quick search for menu items & help articles
Date: Thu, 14 Jan 2021 16:55:54 +0000
Message-ID: <CA+OCxozgWnBkzORFfLD1o0X4Zq9izG26a+LZUZ8encP-Qn6mew@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Hi
On Thu, Jan 14, 2021 at 4:48 PM Pramod Ahire <[email protected]>
wrote:
> Hi Team,
>
>
>
> Please find the attached designs & patch that contains complete
> functionality except below to do for quick search.
>
>
>
> To Do:
>
>
>
> - Unit test cases are not that sufficient to cover complete code, but
> will be working in background to cover up those one
> - In pgadmin, for disabled menu items we need to add info that will
> describe why menu has disabled & how it will be enabled. Either another way
> to enable all of them & show respective reason in popup that menu is
> disabled for.
>
>
>
> Please do let me know if I missed anything or suggestion of yours.
>
Looks very good. I haven't done an extensive code review/test, but two
things spring to mind immediately:
1) I think the search box should be the top item on the Help menu. I do not
think it should be on the far end of the menu bar, as it looks too much
like it will search for data (think of search on a website).
2) Do we need another loading icon? Surely there's one in the source tree
already that we can use?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Quick search for menu items & help articles
In-Reply-To: <CA+OCxozgWnBkzORFfLD1o0X4Zq9izG26a+LZUZ8encP-Qn6mew@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox