public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog
Date: Mon, 18 Jun 2018 18:09:04 +0100
Message-ID: <CA+OCxozvzpGn2QQnutxLwAhV8Ag1Aze-jGn9EtuEQiuGS89YYw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdeG7k45nD=_gM_9qJeASXfPyert1yc7aZoPToVDcHnOQ@mail.gmail.com>
References: <CANxoLDdeG7k45nD=_gM_9qJeASXfPyert1yc7aZoPToVDcHnOQ@mail.gmail.com>

Hi

On Mon, Jun 18, 2018 at 12:18 PM, Akshay Joshi <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is the patch for Feature #3388 Allow to set the connection
> timeout on the server properties dialog. Please review it.
>

I took a quick look at this and had some questions/comments:

- Doc updates seem to be missing.

- The timeout should be passed through to external utilities like
pg_dump/pg_restore.

- Can/should the timeout be extended to the SSH tunnels?

- Any refactoring opportunities in the code you're touching?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog
  In-Reply-To: <CA+OCxozvzpGn2QQnutxLwAhV8Ag1Aze-jGn9EtuEQiuGS89YYw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox