public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog
Date: Wed, 20 Jun 2018 00:59:02 +0100
Message-ID: <CA+OCxoySJxnMKohyHSNXr2W8yJ91yw8t8HDBDBCGbqoDigccPg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDeNUWh3v7i6TjUzOsO0y0_Q1q1RRE_q6uWOhGsCCrtHPQ@mail.gmail.com>
References: <CANxoLDdeG7k45nD=_gM_9qJeASXfPyert1yc7aZoPToVDcHnOQ@mail.gmail.com>
<CA+OCxozvzpGn2QQnutxLwAhV8Ag1Aze-jGn9EtuEQiuGS89YYw@mail.gmail.com>
<CANxoLDdst6=_Co68MuB4W1K0a3Lo9i7poF9hwaPMwprFXdJYyg@mail.gmail.com>
<CANxoLDeNUWh3v7i6TjUzOsO0y0_Q1q1RRE_q6uWOhGsCCrtHPQ@mail.gmail.com>
Thanks, applied.
On Tue, Jun 19, 2018 at 12:18 PM, Akshay Joshi <
[email protected]> wrote:
> Hi
>
> On Tue, Jun 19, 2018 at 2:11 PM, Akshay Joshi <
> [email protected]> wrote:
>
>> Hi
>>
>> On Mon, Jun 18, 2018 at 10:39 PM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Mon, Jun 18, 2018 at 12:18 PM, Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch for Feature #3388 Allow to set the connection
>>>> timeout on the server properties dialog. Please review it.
>>>>
>>>
>>> I took a quick look at this and had some questions/comments:
>>>
>>> - Doc updates seem to be missing.
>>>
>>
>> My bad, again I forgot to do that. Fixed in attached patch.
>>
>>>
>>> - The timeout should be passed through to external utilities like
>>> pg_dump/pg_restore.
>>>
>>
>> I am not able to see any option to set the timeout for
>> pg_dump/pg_restore.
>>
>
> Fixed it by setting environment variable "PGCONNECT_TIMEOUT".
> Attached is the new updated patch.
>
>
>>
>>> - Can/should the timeout be extended to the SSH tunnels?
>>>
>>
>> No option to set the timeout, I have check the sshtunnel's
>> documentation <https://sshtunnel.readthedocs.io/en/latest/;.
>>
>>>
>>> - Any refactoring opportunities in the code you're touching?
>>>
>>
>> Not seen any logic that can be refactored.
>>
>>>
>>> Thanks.
>>>
>>
>> Apart from above, I have found one issue in *datamodel.js* when
>> setting the min value to 0 for input control, it didn't work.
>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog
In-Reply-To: <CA+OCxoySJxnMKohyHSNXr2W8yJ91yw8t8HDBDBCGbqoDigccPg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox