public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: Fix for Feature #4334, RM #4496 and #4497
Date: Thu, 25 Jul 2019 16:38:38 +0100
Message-ID: <CA+OCxozy=dcp5A8yT+q3w+-nKp2QocQvcXfT0Os7kKnHZqnyVw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfkGbeNr--PvqO=9ksXkPmOCZnr8QOEEpECPcr6PtxKDA@mail.gmail.com>
References: <CANxoLDcbVUZUjQiS56g07EHaR3+5340P9QjpES2GC_JoRd5+gg@mail.gmail.com>
<CANxoLDfkGbeNr--PvqO=9ksXkPmOCZnr8QOEEpECPcr6PtxKDA@mail.gmail.com>
Thanks, patch applied.
On Wed, Jul 24, 2019 at 12:58 PM Akshay Joshi <[email protected]>
wrote:
> Hi Hackers,
>
> Attached is the updated patch with Documentation for Identity/Generated
> columns and updated screenshots.
> Please ignore the previous patch.
>
> On Wed, Jul 24, 2019 at 12:39 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> I have added the support of Generated Columns (PG/EPAS 12) and also fixed
>> RM #4496, #4497.
>>
>> During the implementation of that I have also fixed following issues that
>> I encountered:
>>
>> - User should not be able to provide Default value with Identity
>> column.
>> - 'Drop Cascade' button to delete multiple columns should be disabled.
>> - Set "Not Null?" switch to 'Yes' when we create Identity column.
>> - Fix issue when we insert default value for the column and then
>> remove it. It generates wrong msql.
>> - Fix issue when we provide the default value of a column and then
>> select the datatype to serial/bigserial/smallserial, it generates wrong
>> msql.
>>
>> Modified/Added regression test cases for adding Identity column and
>> Generated columns.
>> Please review it.
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: Fix for Feature #4334, RM #4496 and #4497
In-Reply-To: <CA+OCxozy=dcp5A8yT+q3w+-nKp2QocQvcXfT0Os7kKnHZqnyVw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox