public inbox for [email protected]  
help / color / mirror / Atom feed
[pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool
3+ messages / 3 participants
[nested] [flat]

* [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool
@ 2018-06-05 12:28 Akshay Joshi <[email protected]>
  2018-06-05 13:34 ` Re: [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool Victoria Henry <[email protected]>
  2018-06-06 08:24 ` Re: [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool Dave Page <[email protected]>
  0 siblings, 2 replies; 3+ messages in thread

From: Akshay Joshi @ 2018-06-05 12:28 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached is the minor patch to move 'Notifications' tab before "Query
History" in Query Tool.

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


Attachments:

  [application/octet-stream] Move_Notifications_Tab.patch (1.1K, 3-Move_Notifications_Tab.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index cab3d7d..ce39769 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -264,8 +264,8 @@ define('tools.querytool', [
       self.data_output_panel = main_docker.addPanel('data_output', wcDocker.DOCK.BOTTOM, sql_panel_obj);
       self.explain_panel = main_docker.addPanel('explain', wcDocker.DOCK.STACKED, self.data_output_panel);
       self.messages_panel = main_docker.addPanel('messages', wcDocker.DOCK.STACKED, self.data_output_panel);
-      self.history_panel = main_docker.addPanel('history', wcDocker.DOCK.STACKED, self.data_output_panel);
       self.notifications_panel = main_docker.addPanel('notifications', wcDocker.DOCK.STACKED, self.data_output_panel);
+      self.history_panel = main_docker.addPanel('history', wcDocker.DOCK.STACKED, self.data_output_panel);
 
       self.render_history_grid();
       queryToolNotifications.renderNotificationsGrid(self.notifications_panel);


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool
  2018-06-05 12:28 [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool Akshay Joshi <[email protected]>
@ 2018-06-05 13:34 ` Victoria Henry <[email protected]>
  1 sibling, 0 replies; 3+ messages in thread

From: Victoria Henry @ 2018-06-05 13:34 UTC (permalink / raw)
  To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers

Hi Akshay,

LGTM and passes tests.

Sincerely,

Victoria

On Tue, Jun 5, 2018 at 8:28 AM Akshay Joshi <[email protected]>
wrote:

> Hi Hackers,
>
> Attached is the minor patch to move 'Notifications' tab before "Query
> History" in Query Tool.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool
  2018-06-05 12:28 [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool Akshay Joshi <[email protected]>
@ 2018-06-06 08:24 ` Dave Page <[email protected]>
  1 sibling, 0 replies; 3+ messages in thread

From: Dave Page @ 2018-06-06 08:24 UTC (permalink / raw)
  To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Tue, Jun 5, 2018 at 1:28 PM, Akshay Joshi <[email protected]>
wrote:

> Hi Hackers,
>
> Attached is the minor patch to move 'Notifications' tab before "Query
> History" in Query Tool.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2018-06-06 08:24 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-06-05 12:28 [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool Akshay Joshi <[email protected]>
2018-06-05 13:34 ` Victoria Henry <[email protected]>
2018-06-06 08:24 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox