Re: Patch: New field in frmMain statusbar

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Adam Scott <[email protected]>
To: Dave Page <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Patch: New field in frmMain statusbar
Date: Wed, 23 Sep 2015 07:55:29 -0600
Message-ID: <CA+s62-OB98EwCzhV6MGR+w1MG574J6_8OfS8C-shzNXJ5gWvPQ@mail.gmail.com> (raw)
In-Reply-To: <CA+s62-M+TM-TDhUJoz5ap0D2ZLWymXGx9Lnh+cj+E8mSmcmXLA@mail.gmail.com>
References: <CA+s62-Ous9Dr7EFGfwEh-N7xZGh8f173uUU=VbzzgV9crVD4NQ@mail.gmail.com>
	<CA+OCxoxnayiMBczvgwCSvd8vLdJ6zjjAU+Sb68bE+h5JbYH5CA@mail.gmail.com>
	<CABUevEwiW5FJuOp2-eBBWvAURnRV5xDiR6N8ET4juWatLPWsdA@mail.gmail.com>
	<CA+s62-PDmPApuCvzAziewCtZnDD1sAkOwnnwW6odhWaXE2hF+w@mail.gmail.com>
	<CABUevEzVwKWKwOajTSWnC2+8CpcOtp-dYPyYOMEj31eaUXNkAg@mail.gmail.com>
	<CA+OCxox1Ky8VXLEzLNoFj77_V5u=hbjnnvffELk1dicazm=s2A@mail.gmail.com>
	<CABUevEwmoneWk9-n1uJeTxtr7KYzHBmbWEfGwN0Uwx+fR0T4=A@mail.gmail.com>
	<CA+OCxoyL_OaiDW8s+6znck8mYJPzpt95ruqZgz2kA3ZxUdXzMQ@mail.gmail.com>
	<CA+s62-Ndv0B8hDkXMVyhr0o_wHmc3R3HyKfx9nGhXSZNTQgY0w@mail.gmail.com>
	<CA+s62-PP_6ZQmnbzrn2Vb0iLiVHdp6jYsUb33jAYjTqRV93tUw@mail.gmail.com>
	<CA+OCxowaBvS3szDk4Jc0F=nSkDG52JWguFpSc1BgPZ9xgbzeXA@mail.gmail.com>
	<CA+s62-M+TM-TDhUJoz5ap0D2ZLWymXGx9Lnh+cj+E8mSmcmXLA@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Is the last patch okay?  If there's something more required or anything
please let me know.

Thank you,
Adam


On Thu, Sep 17, 2015 at 7:47 AM, Adam Scott <[email protected]> wrote:

> Being consistent with the frmQuery probably helps the user as well.
> Here's the patch to display the connection name as it is displayed in the
> frmQuery.
>
> Thank you,
> Adam
>
>
> On Wed, Sep 16, 2015 at 9:30 AM, Dave Page <[email protected]> wrote:
>
>> I think so - I realise it's not the display name (which would be
>> ideal), but it is a condensed name that fully describes the
>> connection.
>>
>> On Tue, Sep 15, 2015 at 4:01 PM, Adam Scott <[email protected]>
>> wrote:
>> > If it displayed what's displayed in the Query editor would that be
>> better?
>> >
>> > Thank you,
>> > Adam
>> >
>> >
>> > On Tue, Sep 15, 2015 at 8:41 AM, Adam Scott <[email protected]>
>> wrote:
>> >>
>> >> If you have a development host and a production host, the database
>> names
>> >> will be the same.  I think the value of the having the new field goes
>> away
>> >> if you exclude the hostname.  You won't know what host the object you
>> are
>> >> selecting belongs to.  That could be the difference between modifying
>> an
>> >> object in development and production.
>> >>
>> >> It seems to me that what you could say about the display name is what
>> >> could be said about the connection's display name in the tree control
>> since
>> >> this is what is displayed (plus the database name).
>> >>
>> >> What the patch displays answers the questions, "What connection am I
>> on?"
>> >> "What database am I on?"
>> >>
>> >> I guess I can work on adding another patch that allows you to customize
>> >> what is displayed using frmOptions...?
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >> On Tue, Sep 15, 2015 at 5:20 AM, Dave Page <[email protected]> wrote:
>> >>>
>> >>> On Tue, Sep 15, 2015 at 12:14 PM, Magnus Hagander <
>> [email protected]>
>> >>> wrote:
>> >>> > On Tue, Sep 15, 2015 at 10:55 AM, Dave Page <[email protected]>
>> wrote:
>> >>> >>
>> >>> >> On Mon, Sep 14, 2015 at 5:11 PM, Magnus Hagander <
>> [email protected]>
>> >>> >> wrote:
>> >>> >> > The part that changed is just the one that added db1 and db2,
>> right?
>> >>> >>
>> >>> >> It's the server display name *and* the database name, so to give a
>> >>> >> (redacted) example from my machine, I would have:
>> >>> >>
>> >>> >> aws-ap-southeast-1b.xxxxxxxxxxxxxxxx.com (aws-ap-southeast-1b.
>> >>> >> xxxxxxxxxxxxxxxx.com:5432):postgres
>> >>> >>
>> >>> >> Which as you can see is quite long.
>> >>> >
>> >>> >
>> >>> > I thought the point of display names was to have them nice and
>> short :)
>> >>> > I've
>> >>> > certainly never used displaynames that are that long.
>> >>>
>> >>> I generally use the full hostnames (as I have machines in multiple
>> >>> domains) - and in the places that you currently see them, that length
>> >>> is actually fine.
>> >>>
>> >>> > Yes, I totally see with names like that it becomes annoying, and
>> >>> > certainly
>> >>> > not easy to parse. Perhaps what we really shoul dhave is just
>> >>> > displayname +
>> >>> > databasename, and exclude the actual hostname?
>> >>>
>> >>> That would be an improvement, certainly.
>> >>>
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Patch: New field in frmMain statusbar
  In-Reply-To: <CA+s62-OB98EwCzhV6MGR+w1MG574J6_8OfS8C-shzNXJ5gWvPQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox