Re: patch for cast module

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Sanket Mehta <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: patch for cast module
Date: Mon, 15 Feb 2016 13:40:26 +0530
Message-ID: <CA+yw=mM9knpdKBfiP63t1nO=h2PCgWjPaaWnw+eQ1S6AYy7K8A@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxow0Q5mLbTijw-fQ2_RGpkFTJ-K9hKFPFFxY-NSTLxgJJw@mail.gmail.com>
References: <CA+yw=mPCZvZ7+L+g6peQjEe9cihHFUgT4hW3X9ASTRg3wdJgpQ@mail.gmail.com>
	<CA+yw=mORG-LGpa948F8RzbiQkZ3eUmr_3mgqS+akRGx-640Z+Q@mail.gmail.com>
	<CACCA4P1y5u3kmWn+cV7qb9JKCHrAKw-x4kWmbiHSdrcxDfT0bw@mail.gmail.com>
	<CA+yw=mOi=xbgHophMuhw+D9sdmv=rLoubqG8RALQ+1Hw0nZ92g@mail.gmail.com>
	<CA+yw=mOD9i_tLu4r5qpGw1Gd9PKY3xRg4gDHKm010eKPHiCMmQ@mail.gmail.com>
	<CANxoLDedHH+i9hpma8Q3SUiFWU+fMUO_eGtLU+ECmF4fOii_og@mail.gmail.com>
	<CA+yw=mMPQzqmfcpdoJmrvBoA+wc_0758TNDjrF1w1RXHxYsGDw@mail.gmail.com>
	<CANxoLDdESMArY0HvraikVDtBwE4sFqtn0FpSNkohU1R3_vQsNA@mail.gmail.com>
	<CA+yw=mPjs2xqN162encZzWsdUNYBQvKUzHvPcTg3DLirDSe9fA@mail.gmail.com>
	<CA+OCxow0Q5mLbTijw-fQ2_RGpkFTJ-K9hKFPFFxY-NSTLxgJJw@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Dave,

Regarding your suggestion of putting some comments in javascript, I think I
have already put some comments regarding model data and their controls if
any extended.

Can you please let me know where exactly you think more comments are
required?


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Feb 12, 2016 at 9:54 PM, Dave Page <[email protected]> wrote:

>
>
> On Fri, Feb 12, 2016 at 11:57 AM, Sanket Mehta <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> PFA the updated patch.
>>
>>
> Hi
>
> When testing this patch, I get the following error:
>
> Traceback (most recent call last):
>   File "pgAdmin4.py", line 56, in <module>
>     app = create_app()
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/__init__.py", line 194, in
> create_app
>     app.register_blueprint(module)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 62, in wrapper_func
>     return f(self, *args, **kwargs)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 889, in register_blueprint
>     blueprint.register(self, options, first_registration)
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/__init__.py", line 40,
> in register
>     app.register_blueprint(module)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 62, in wrapper_func
>     return f(self, *args, **kwargs)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 889, in register_blueprint
>     blueprint.register(self, options, first_registration)
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/__init__.py", line 40,
> in register
>     app.register_blueprint(module)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 62, in wrapper_func
>     return f(self, *args, **kwargs)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 889, in register_blueprint
>     blueprint.register(self, options, first_registration)
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
> line 147, in register
>     super(ServerModule, self).register(app, options, first_registration)
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/__init__.py", line 40,
> in register
>     app.register_blueprint(module)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 62, in wrapper_func
>     return f(self, *args, **kwargs)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 889, in register_blueprint
>     blueprint.register(self, options, first_registration)
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/__init__.py", line 37,
> in register
>     self.submodules = list(app.find_submodules(self.import_name))
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/__init__.py", line 42, in
> find_submodules
>     module = import_module(module_name)
>   File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/__init__.py",
> line 37, in import_module
>     __import__(name)
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/casts/__init__.py",
> line 21, in <module>
>     from html import escape
> ImportError: No module named html
>
> Other comments:
>
> - Leave a blank line before the header block and the first line of Python
> code please.
> - There is no pydoc description for the module.
> - The javascript is almost completely devoid of comments. There should be
> at least a minimal amount to explain what each code block is doing.
> - There should be no blank lines at the top of SQL templates (e.g.
> create.sql).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (24+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: patch for cast module
  In-Reply-To: <CA+yw=mM9knpdKBfiP63t1nO=h2PCgWjPaaWnw+eQ1S6AYy7K8A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox