public inbox for [email protected]  

help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: Sanket Mehta <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: patch for cast module
Date: Wed, 20 Jan 2016 10:20:52 +0530
Message-ID: <CACCA4P1y5u3kmWn+cV7qb9JKCHrAKw-x4kWmbiHSdrcxDfT0bw@mail.gmail.com> (raw)
In-Reply-To: <CA+yw=mORG-LGpa948F8RzbiQkZ3eUmr_3mgqS+akRGx-640Z+Q@mail.gmail.com>
References: <CA+yw=mPCZvZ7+L+g6peQjEe9cihHFUgT4hW3X9ASTRg3wdJgpQ@mail.gmail.com>
	<CA+yw=mORG-LGpa948F8RzbiQkZ3eUmr_3mgqS+akRGx-640Z+Q@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Sanket,

Below are the review comments.

- When we edit any existing cast node then it gives error "*Response object
has no attribute strip*". This error is coming because generated SQL is
  wrong.
- Unnecessary debug logs are coming on console. Please remove unnecessary
debug logs.
- In some of the sql file, 'qtIdent' and 'qtLiteral' is not used. Please
check all the SQL files.
- "Delete" cast functionality is not working. Error is getting displayed
saying *"syntax error at or near "castsource"*.
- "Delete cascade" functionality is not working - error is getting
displayed saying *"The requested URL not found".*
- Do the proper comments, in some of the function like "script_load" ,
comments are wrong.
- Is "configs" really required in __init__.py file ? We have not seen any
usage for this. Please remove it if it is not required.
- Remove commented code from the source file.

Please check all the generated SQL statements . Test the basic
functionality of "create", "Edit" and "Delete" node before sending patch
file.

Do let us know for any comments/issues.

Thanks,
Neel Patel

On Tue, Jan 19, 2016 at 8:06 PM, Sanket Mehta <[email protected]
> wrote:

> Hi,
>
> PFA updated patch for cast module as per check list provided by Neel.
> Please do review it and let me know in case of anything is missing.
>
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Mon, Jan 18, 2016 at 7:16 PM, Sanket Mehta <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA patch for cast module.
>> Please do review it and let me know in case of any issue.
>>
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

view thread (24+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: patch for cast module
  In-Reply-To: <CACCA4P1y5u3kmWn+cV7qb9JKCHrAKw-x4kWmbiHSdrcxDfT0bw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox