public inbox for [email protected]
help / color / mirror / Atom feedPATCH: resolving issue in casts as functions are not being fetched due to change in node.ui.js
2+ messages / 2 participants
[nested] [flat]
* PATCH: resolving issue in casts as functions are not being fetched due to change in node.ui.js
@ 2016-04-22 11:04 Sanket Mehta <[email protected]>
2016-04-22 12:37 ` Re: PATCH: resolving issue in casts as functions are not being fetched due to change in node.ui.js Ashesh Vashi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Sanket Mehta @ 2016-04-22 11:04 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
Due to commit id 944bdbb96c3b360c856d7586144b835e44afac43 in node.ui.js,
functions were not being fetched after selecting source and target types as
I have overridden the options property for functions select control.
I have resolved that issue and patch is attached with this mail.
Please do review it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[text/x-patch] options_issue_in_casts.patch (1.6K, 3-options_issue_in_casts.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js b/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js
index 690a6d5..0010222 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js
@@ -177,20 +177,19 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
type: 'text', disabled: function(m) { return !m.isNew(); },
group: 'Definition', mode: ['create'],
control: 'node-ajax-options',
- options: function() {
-
- var srcTyp = this.model.get('srctyp');
- var trgtyp = this.model.get('trgtyp');
+ options: function(control) {
+ var srcTyp = control.model.get('srctyp');
+ var trgtyp = control.model.get('trgtyp');
var res = [];
if(srcTyp != undefined && srcTyp != '' &&
trgtyp != undefined && trgtyp != '')
{
- var node = this.field.get('schema_node'),
+ var node = control.field.get('schema_node'),
_url = node.generate_url.apply(
node, [
- null, 'get_functions', this.field.get('node_data'), false,
- this.field.get('node_info')
+ null, 'get_functions', control.field.get('node_data'), false,
+ control.field.get('node_info')
]);
$.ajax({
type: 'POST',
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: PATCH: resolving issue in casts as functions are not being fetched due to change in node.ui.js
2016-04-22 11:04 PATCH: resolving issue in casts as functions are not being fetched due to change in node.ui.js Sanket Mehta <[email protected]>
@ 2016-04-22 12:37 ` Ashesh Vashi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Ashesh Vashi @ 2016-04-22 12:37 UTC (permalink / raw)
To: Sanket Mehta <[email protected]>; +Cc: pgadmin-hackers
Committed!
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
On Fri, Apr 22, 2016 at 4:34 PM, Sanket Mehta <[email protected]
> wrote:
> Hi,
>
> Due to commit id 944bdbb96c3b360c856d7586144b835e44afac43 in node.ui.js,
> functions were not being fetched after selecting source and target types
> as I have overridden the options property for functions select control.
>
> I have resolved that issue and patch is attached with this mail.
>
> Please do review it.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-04-22 12:37 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-04-22 11:04 PATCH: resolving issue in casts as functions are not being fetched due to change in node.ui.js Sanket Mehta <[email protected]>
2016-04-22 12:37 ` Ashesh Vashi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox