public inbox for [email protected]  

help / color / mirror / Atom feed

From: Sanket Mehta <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: FTS Dictionary
Date: Fri, 15 Apr 2016 01:29:01 +0530
Message-ID: <CA+yw=mOTAwv+x-uQjvSJjgs85kMVxHFbd93kHhnCnJnH9LsKVA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozj1SnuXBcrtUKqewmd6TY2odO+JkoUVSJUUx=oBgnfdQ@mail.gmail.com>
References: <CA+yw=mPpQn+3QZzUc1iE9_YdHO7-nUP-+RwTChUVnnUd7xDSuA@mail.gmail.com>
	<CA+OCxozj1SnuXBcrtUKqewmd6TY2odO+JkoUVSJUUx=oBgnfdQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks for reviewing it Dave.
I will resolve these issues ASAP.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Apr 15, 2016 at 1:27 AM, Dave Page <[email protected]> wrote:

> On Thu, Apr 14, 2016 at 3:41 PM, Sanket Mehta
> <[email protected]> wrote:
> > Hi,
> >
> > PFA patch for FTS Dictionaries.
> > Please do review it and let me know in case of any issues.
>
> Thanks - committed with a few cosmetic changes, and a couple of minor
> issues to resolve:
>
> 1) The template is not shown in properties views if it is not in a
> system schema (because of the way you are dealing with schema names
> etc). Please also check how the existing code will behave, if there is
> a template in the public schema with the same name as one in
> pg_catalog.
>
> 2) Please strip the quotes from the options before displaying them.
>
> I'll create a card for this.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: PATCH: FTS Dictionary
  In-Reply-To: <CA+yw=mOTAwv+x-uQjvSJjgs85kMVxHFbd93kHhnCnJnH9LsKVA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox