public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nagesh Dhope <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified
Date: Fri, 6 Mar 2020 12:20:50 +0530
Message-ID: <CAA3zdZoVf-A32=m6DYiizzeNLZRFYM0yAq-S9Pt4eYPh_SfU7g@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfid6kWwA9ziDN6H4NVj+x1jyWAs1ftVJTVsFfaBFE9rw@mail.gmail.com>
References: <CAM9w-_n8hzWzjP33g-KFy-BpBk-t6_u26U7M8atkHD8z4+3nyw@mail.gmail.com>
<CANxoLDfuP+rZQMtAzg7yqDf=s4jc41y6Rqp63_nMzXi43hvqPQ@mail.gmail.com>
<CAM9w-_=Qq-CLLxMPNY6t48=9ETq9kQRz7Q-+BfGZrqWTnARZaA@mail.gmail.com>
<CANxoLDfid6kWwA9ziDN6H4NVj+x1jyWAs1ftVJTVsFfaBFE9rw@mail.gmail.com>
Hi Akshay,
Please find a patch to make controls under *Active query details* subnode
read-only on the dashboard.
On Fri, Jan 31, 2020 at 12:38 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, patch applied.
>
> On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch to include dialogs (create/edit) for all
>> the nodes.
>> Kindly review.
>>
>> On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Aditya
>>>
>>> As per discussion, we should visit all the nodes create/edit dialog and
>>> make the controls read-only wherever appropriate.
>>>
>>> On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch to allow input controls to be set as readonly
>>>> instead of disabled.
>>>> I've also changed the code for the nodes to make sure properties tab
>>>> have readonly fields wherever applicable. This will allow tab navigation in
>>>> properties tab and also allow screen readers to read it.
>>>> Please note that, I've not visited each and every node create/edit
>>>> dialog to identify what should be readonly or what should be disabled as it
>>>> depends on business logic. The patch is mainly for the properties tab.
>>>>
>>>> Kindly review.
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Nagesh
Attachments:
[application/octet-stream] RM4993_v3.patch (1.2K, 3-RM4993_v3.patch)
download | inline diff:
diff --git a/web/pgadmin/dashboard/static/js/dashboard.js b/web/pgadmin/dashboard/static/js/dashboard.js
index 0969a5c..a0d5f63 100644
--- a/web/pgadmin/dashboard/static/js/dashboard.js
+++ b/web/pgadmin/dashboard/static/js/dashboard.js
@@ -167,7 +167,7 @@ define('pgadmin.dashboard', [
label: gettext('Backend type'),
type: 'text',
editable: true,
- disabled: true,
+ readonly: true,
group: gettext('Details'),
visible: function() {
return this.version >= 100000;
@@ -177,21 +177,21 @@ define('pgadmin.dashboard', [
label: gettext('Query started at'),
type: 'text',
editable: false,
- disabled: true,
+ readonly: true,
group: gettext('Details'),
}, {
id: 'state_change',
label: gettext('Last state changed at'),
type: 'text',
editable: true,
- disabled: true,
+ readonly: true,
group: gettext('Details'),
}, {
id: 'query',
label: gettext('SQL'),
type: 'text',
editable: true,
- disabled: true,
+ readonly: true,
control: Backform.SqlFieldControl,
group: gettext('Details'),
}],
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified
In-Reply-To: <CAA3zdZoVf-A32=m6DYiizzeNLZRFYM0yAq-S9Pt4eYPh_SfU7g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox