public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nagesh Dhope <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM4896] Close Open/Save Dialog in query tool on Escape key
Date: Fri, 8 Nov 2019 16:17:47 +0530
Message-ID: <CAA3zdZp3H_Bg3MwnQkCusgPigpJHkcsO=Cr45ezDn+cRiDxotg@mail.gmail.com> (raw)

Hi Hackers,
Please find an attached patch for closing Open/Save dialog in the query
tool on the escape key.

-- 
Thanks,
Nagesh


Attachments:

  [application/octet-stream] RM4896.patch (648B, 3-RM4896.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index ee370a2..70d4bd3 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -2256,7 +2256,7 @@ define('tools.querytool', [
          * loses focus and events don't work.
          */
         $(window).on('keydown', (e)=>{
-          if(self.gridView.keyAction) {
+          if(($('.sql-editor').find(e.target).length !== 0 || e.target == $('body.wcDesktop')[0]) && self.gridView.keyAction) {
             self.gridView.keyAction(e);
           }
         });

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM4896] Close Open/Save Dialog in query tool on Escape key
  In-Reply-To: <CAA3zdZp3H_Bg3MwnQkCusgPigpJHkcsO=Cr45ezDn+cRiDxotg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox