public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin][RM4896] Close Open/Save Dialog in query tool on Escape key
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM4896] Close Open/Save Dialog in query tool on Escape key
@ 2019-11-08 10:47  Nagesh Dhope <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Nagesh Dhope @ 2019-11-08 10:47 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,
Please find an attached patch for closing Open/Save dialog in the query
tool on the escape key.

-- 
Thanks,
Nagesh


Attachments:

  [application/octet-stream] RM4896.patch (648B, 3-RM4896.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index ee370a2..70d4bd3 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -2256,7 +2256,7 @@ define('tools.querytool', [
          * loses focus and events don't work.
          */
         $(window).on('keydown', (e)=>{
-          if(self.gridView.keyAction) {
+          if(($('.sql-editor').find(e.target).length !== 0 || e.target == $('body.wcDesktop')[0]) && self.gridView.keyAction) {
             self.gridView.keyAction(e);
           }
         });


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM4896] Close Open/Save Dialog in query tool on Escape key
@ 2019-11-08 12:57  Akshay Joshi <[email protected]>
  parent: Nagesh Dhope <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2019-11-08 12:57 UTC (permalink / raw)
  To: Nagesh Dhope <[email protected]>; +Cc: pgadmin-hackers

Thanks, patch applied.

On Fri, Nov 8, 2019 at 4:18 PM Nagesh Dhope <[email protected]>
wrote:

> Hi Hackers,
> Please find an attached patch for closing Open/Save dialog in the query
> tool on the escape key.
>
> --
> Thanks,
> Nagesh
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2019-11-08 12:57 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-11-08 10:47 [pgAdmin][RM4896] Close Open/Save Dialog in query tool on Escape key Nagesh Dhope <[email protected]>
2019-11-08 12:57 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox