public inbox for [email protected]
help / color / mirror / Atom feedFrom: Paresh More <[email protected]>
To: Fahar Abbas <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Dave Page <[email protected]>
Subject: Re: pgAgent 4.0 patch
Date: Thu, 7 Jun 2018 12:09:43 +0530
Message-ID: <CAAgiCNETFa7nBrDF52YWkZTKnbo4SK3Td_daf_E0-zSsFO_Fvg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozkh2UU-r1Wa-yo9_0t8G4ee5PhV8b3isfX8KWKwoZqTQ@mail.gmail.com>
References: <CA+OCxowwmOPXkNK334LuBx9uMo_wTeECQKHG4waq_e4Rfde_LA@mail.gmail.com>
<CAG7mmoxK2A55Sq4ft=fApKkg=8taQTQXgW2eUBsNmvKo0HsF7w@mail.gmail.com>
<CA+OCxozkh2UU-r1Wa-yo9_0t8G4ee5PhV8b3isfX8KWKwoZqTQ@mail.gmail.com>
Hello Fahar,
File, pgagent-4.0.0-1-linux-x64.run is uploaded @
https://uploads.enterprisedb.com/download.php?file=bd89aec08d73ceae21cf560c391598f6
On Tue, Jun 5, 2018 at 3:10 PM, Dave Page <[email protected]> wrote:
> Thanks, committed with those changes.
>
> Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS
> Bitrock installers) from git head for Fahar to test?
>
> Once he's happy with them, I'll tag and build the community packages.
>
> Thanks!
>
> On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi <
> [email protected]> wrote:
>
>> On Mon, Jun 4, 2018 at 10:04 PM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> Can you review the attached please Ashesh?
>>>
>> Hi Dave,
>>
>> Due to the wrong pattern in '.gitignore', it was ignoring the new file
>> 'sql/pgagent--3.4--4.0.sql'.
>> We should ignore only the '*.sql' in the root directory.
>> Something like this.
>>
>> *$ git diff .gitignore*
>> *diff --git a/.gitignore b/.gitignore*
>> *index 9883354..40fe7a9 100644*
>> *--- a/.gitignore*
>> *+++ b/.gitignore*
>> *@@ -6,7 +6,12 @@ CPackSourceConfig.cmake*
>> * Makefile*
>> * cmake_install.cmake*
>> * install_manifest.txt*
>> *-pgagent*
>> *+# Ignore 'pgagent' & 'pgagent.control' in root directory only.*
>> *+/pgagent*
>> *+!/*/pgagent*
>> * pgagent.control*
>> *+!/*/pgagent.control*
>> * *.log*
>> *-*.sql*
>> *+# Ignore '*.sql' files in root directory only.*
>> *+/*.sql*
>> *+!/*/*.sql*
>>
>>
>> And, I am getting the following warning applying the patch.
>>
>> *$ git apply ~/Downloads/pgagent-4.0-update.diff*
>> */Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing
>> whitespace.*
>> *//*
>> *warning: 1 line adds whitespace errors.*
>>
>>
>> Otherwise - it looks good to me.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi
>> <http://www.linkedin.com/in/asheshvashi>*
>>
>>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks & Regards
*Paresh More*
[image: NEW-EDB-logo-4c]
Pune, India.
Cell : +919922000564 | www.enterprisedb.com
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgAgent 4.0 patch
In-Reply-To: <CAAgiCNETFa7nBrDF52YWkZTKnbo4SK3Td_daf_E0-zSsFO_Fvg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox