public inbox for [email protected]  

help / color / mirror / Atom feed
From: Rohit Bhati <[email protected]>
To: [email protected]
Subject: Re: Require suggestions for Issue #2874
Date: Fri, 6 Sep 2024 13:48:38 +0530
Message-ID: <CABscKViGC-C6dBx6c=M3TQvCXrM+KGXWED7cj9BX2uB7qNb0Tg@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELcYWCYdQ9jF6sV=PkZJ-hkF7Pxt-a3Gi61JzFx=AoGb6w@mail.gmail.com>
References: <CABscKVgnoB8=KcYSa0tp8LAwdw4Gq4-G5ywcmWz353jtH8RH1A@mail.gmail.com>
	<CABscKVg+1gh1CjPPX8k4_9A407hzfd8DTbP7e0U+-jcoO7awQg@mail.gmail.com>
	<CA+OCxoxiy6xc9V9qUOP0f5LSA22PwHyNFWXjMvBT10EHjF5F+g@mail.gmail.com>
	<CABscKViG4=vECzrEhQNKbwGKJwPrWDn3isw-mPA5fNphw-G6=Q@mail.gmail.com>
	<CA+OCxoxOzUKjPF8pC=z4vjVKegBzNUDtGtwc5tewmtz2MfMhMw@mail.gmail.com>
	<CABscKViS50079irxJfgL5ARtd5g4D86z+OwJ7huY7nRJbB2rLQ@mail.gmail.com>
	<CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com>
	<CA+OCxoy5Mz53vyebx+2V0U3KH9f+Pd-p-HWoM7dMnUYNrjP-nw@mail.gmail.com>
	<CAFOhELcYWCYdQ9jF6sV=PkZJ-hkF7Pxt-a3Gi61JzFx=AoGb6w@mail.gmail.com>

Hi,

I have removed the border and background color, just made the row numbers
bold.

I have attached screenshots showing how the updates look across all themes.


On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
[email protected]> wrote:

>
>
> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> I have made changes for issue #7863
>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
>>> requirements.
>>>
>>> I have attached screenshots showing how the updates look across all
>>> themes for your reference.
>>>
>>> If the current color does not fit well with the theme or if you have any
>>> suggestions for improvements, please let me know.
>>>
>>
>> Is the colour contrast high enough on the row numbers for selected rows
>> in the high contrast theme? The black on grey seems like it might not be to
>> me, but I haven't tested.
>>
>> I wonder also if we should make the row numbers bold all the time.
>> Thoughts?
>>
> We can check how it looks. Also the cell border doesn't look good to me.
>
>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>


Attachments:

  [image/png] Bold-Dark.png (128.9K, ../CABscKViGC-C6dBx6c=M3TQvCXrM+KGXWED7cj9BX2uB7qNb0Tg@mail.gmail.com/3-Bold-Dark.png)
  download | view image

  [image/png] bold-HC.png (145.1K, ../CABscKViGC-C6dBx6c=M3TQvCXrM+KGXWED7cj9BX2uB7qNb0Tg@mail.gmail.com/4-bold-HC.png)
  download | view image

  [image/png] bold-std.png (140.3K, ../CABscKViGC-C6dBx6c=M3TQvCXrM+KGXWED7cj9BX2uB7qNb0Tg@mail.gmail.com/5-bold-std.png)
  download | view image

view thread (33+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: Require suggestions for Issue #2874
  In-Reply-To: <CABscKViGC-C6dBx6c=M3TQvCXrM+KGXWED7cj9BX2uB7qNb0Tg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox