public inbox for [email protected]  

help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded server in runtime on Windows
Date: Thu, 18 May 2017 20:12:17 +0530
Message-ID: <CACCA4P0KyPQj=Q4EieTvs1JH=LTkvjHOTEZytbu-CFB+_L5zbQ@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Dave,

Please find attached patch for the fix of RM#2398 - "Proxy not bypassed for
embedded server in runtime on Windows".

*Observation:-*
We have observed this issue only with Qt WebEngine. We have not observed
this issue with Webkit ( Tested with Qt 5.3 ).

*Issue:-*
If user set option "Bypass proxy server for local addresses" then WebEngine
doesn't bypass the request for local addresses even if that option is set.

*Solution:-*
Now if user set option "Bypass proxy server for local addresses" then Web
Engine bypass the request for localhost and if user unset then request will
not be bypassed.

Please find attached fix for this issue. Do review and test it and let me
know for any issue.

Thanks,
Neel Patel


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] RM_2398.patch (676B, 3-RM_2398.patch)
  download | inline diff:
diff --git a/runtime/pgAdmin4.cpp b/runtime/pgAdmin4.cpp
index a2dbe74..865e6ad 100644
--- a/runtime/pgAdmin4.cpp
+++ b/runtime/pgAdmin4.cpp
@@ -327,6 +327,12 @@ int main(int argc, char * argv[])
     browserWindow.setWindowIcon(QIcon(":/pgAdmin4.ico"));
     browserWindow.show();
 
+    // Disable platform specific proxy settings.
+    // This is required for QtWebEngine on windows platform.
+    // If user has already set the proxy server then "Bypass proxy for localhost"
+    // options is required to enable to make the application working.
+    QNetworkProxyFactory::setUseSystemConfiguration(false);
+
     // Go!
     splash->finish(NULL);
     return app.exec();

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded server in runtime on Windows
  In-Reply-To: <CACCA4P0KyPQj=Q4EieTvs1JH=LTkvjHOTEZytbu-CFB+_L5zbQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox