public inbox for [email protected]  

help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios
Date: Thu, 5 Apr 2018 10:52:10 +0530
Message-ID: <CACCA4P0TS39JP8-MQdTq5Nmz=4MprG3gbZZGR5_u5O8ML82P7A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi Akshay,

Due to above commit, when user "Drop" any database it gives exception in
browser console.
Check attached screenshot.

Thanks,
Neel Patel



On Wed, Mar 21, 2018 at 2:08 PM, Dave Page <[email protected]> wrote:

> Fix a number of broken connection detection scenarios.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 637f3b9d1a54df8b9a1bfad9e26f27fdea407683
> Author: Akshay Joshi <[email protected]>
>
> Modified Files
> --------------
> web/pgadmin/dashboard/static/js/dashboard.js       | 58
> ++++++++++++--------
> web/pgadmin/static/js/sqleditor/execute_query.js   | 62
> +++++++++++----------
> .../js/sqleditor/is_new_transaction_required.js    |  9 ++++
> web/pgadmin/tools/sqleditor/__init__.py            |  4 +-
> web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 20 ++++---
> .../tools/sqleditor/tests/test_start_query_tool.py |  2 +-
> .../tools/sqleditor/utils/start_running_query.py   | 63
> ++++++++++------------
> .../utils/tests/test_start_running_query.py        | 15 +++++-
> .../user_management/static/js/user_management.js   | 13 ++++-
> .../utils/driver/psycopg2/server_manager.py        |  1 +
> .../javascript/sqleditor/execute_query_spec.js     | 48 ++++++++++++-----
> .../sqleditor/is_new_transaction_required_spec.js  | 14 ++---
> 12 files changed, 195 insertions(+), 114 deletions(-)
>
>


Attachments:

  [image/png] db_drop_error.png (316.4K, 3-db_drop_error.png)
  download | view image

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios
  In-Reply-To: <CACCA4P0TS39JP8-MQdTq5Nmz=4MprG3gbZZGR5_u5O8ML82P7A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox