public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Fix a number of broken connection detection scenarios
4+ messages / 3 participants
[nested] [flat]
* pgAdmin 4 commit: Fix a number of broken connection detection scenarios
@ 2018-03-21 08:38 Dave Page <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Dave Page @ 2018-03-21 08:38 UTC (permalink / raw)
To: pgadmin-hackers
Fix a number of broken connection detection scenarios.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=637f3b9d1a54df8b9a1bfad9e26f27fdea40...
Author: Akshay Joshi <[email protected]>
Modified Files
--------------
web/pgadmin/dashboard/static/js/dashboard.js | 58 ++++++++++++--------
web/pgadmin/static/js/sqleditor/execute_query.js | 62 +++++++++++----------
.../js/sqleditor/is_new_transaction_required.js | 9 ++++
web/pgadmin/tools/sqleditor/__init__.py | 4 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 20 ++++---
.../tools/sqleditor/tests/test_start_query_tool.py | 2 +-
.../tools/sqleditor/utils/start_running_query.py | 63 ++++++++++------------
.../utils/tests/test_start_running_query.py | 15 +++++-
.../user_management/static/js/user_management.js | 13 ++++-
.../utils/driver/psycopg2/server_manager.py | 1 +
.../javascript/sqleditor/execute_query_spec.js | 48 ++++++++++++-----
.../sqleditor/is_new_transaction_required_spec.js | 14 ++---
12 files changed, 195 insertions(+), 114 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios
@ 2018-04-05 05:22 Neel Patel <[email protected]>
parent: Dave Page <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Neel Patel @ 2018-04-05 05:22 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Akshay,
Due to above commit, when user "Drop" any database it gives exception in
browser console.
Check attached screenshot.
Thanks,
Neel Patel
On Wed, Mar 21, 2018 at 2:08 PM, Dave Page <[email protected]> wrote:
> Fix a number of broken connection detection scenarios.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 637f3b9d1a54df8b9a1bfad9e26f27fdea407683
> Author: Akshay Joshi <[email protected]>
>
> Modified Files
> --------------
> web/pgadmin/dashboard/static/js/dashboard.js | 58
> ++++++++++++--------
> web/pgadmin/static/js/sqleditor/execute_query.js | 62
> +++++++++++----------
> .../js/sqleditor/is_new_transaction_required.js | 9 ++++
> web/pgadmin/tools/sqleditor/__init__.py | 4 +-
> web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 20 ++++---
> .../tools/sqleditor/tests/test_start_query_tool.py | 2 +-
> .../tools/sqleditor/utils/start_running_query.py | 63
> ++++++++++------------
> .../utils/tests/test_start_running_query.py | 15 +++++-
> .../user_management/static/js/user_management.js | 13 ++++-
> .../utils/driver/psycopg2/server_manager.py | 1 +
> .../javascript/sqleditor/execute_query_spec.js | 48 ++++++++++++-----
> .../sqleditor/is_new_transaction_required_spec.js | 14 ++---
> 12 files changed, 195 insertions(+), 114 deletions(-)
>
>
Attachments:
[image/png] db_drop_error.png (316.4K, 3-db_drop_error.png)
download | view image
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios
@ 2018-04-05 05:57 Akshay Joshi <[email protected]>
parent: Neel Patel <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Akshay Joshi @ 2018-04-05 05:57 UTC (permalink / raw)
To: Neel Patel <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi Neel
This issue is not due to the above fix, if you can see the error it is
showing in dashboard.js line no 454 "err = JSON.parse(xhr.responseText);"
that code is from long time.
I have just added an extra check of the readyState in case of server is
down in the above commit.
Though it is a bug can you please create a new RM for this.
On Thu, Apr 5, 2018 at 10:52 AM, Neel Patel <[email protected]>
wrote:
> Hi Akshay,
>
> Due to above commit, when user "Drop" any database it gives exception in
> browser console.
> Check attached screenshot.
>
> Thanks,
> Neel Patel
>
>
>
> On Wed, Mar 21, 2018 at 2:08 PM, Dave Page <[email protected]> wrote:
>
>> Fix a number of broken connection detection scenarios.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=637f3b9d1a54df8b9a1bfad9e26f27fdea407683
>> Author: Akshay Joshi <[email protected]>
>>
>> Modified Files
>> --------------
>> web/pgadmin/dashboard/static/js/dashboard.js | 58
>> ++++++++++++--------
>> web/pgadmin/static/js/sqleditor/execute_query.js | 62
>> +++++++++++----------
>> .../js/sqleditor/is_new_transaction_required.js | 9 ++++
>> web/pgadmin/tools/sqleditor/__init__.py | 4 +-
>> web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 20 ++++---
>> .../tools/sqleditor/tests/test_start_query_tool.py | 2 +-
>> .../tools/sqleditor/utils/start_running_query.py | 63
>> ++++++++++------------
>> .../utils/tests/test_start_running_query.py | 15 +++++-
>> .../user_management/static/js/user_management.js | 13 ++++-
>> .../utils/driver/psycopg2/server_manager.py | 1 +
>> .../javascript/sqleditor/execute_query_spec.js | 48 ++++++++++++-----
>> .../sqleditor/is_new_transaction_required_spec.js | 14 ++---
>> 12 files changed, 195 insertions(+), 114 deletions(-)
>>
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios
@ 2018-04-05 09:12 Neel Patel <[email protected]>
parent: Akshay Joshi <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Neel Patel @ 2018-04-05 09:12 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Thanks,
RM#3249 created for the same.
Regards,
Neel Patel
On Thu, Apr 5, 2018 at 11:27 AM, Akshay Joshi <[email protected]
> wrote:
> Hi Neel
>
> This issue is not due to the above fix, if you can see the error it is
> showing in dashboard.js line no 454 "err = JSON.parse(xhr.responseText);"
> that code is from long time.
> I have just added an extra check of the readyState in case of server is
> down in the above commit.
> Though it is a bug can you please create a new RM for this.
>
> On Thu, Apr 5, 2018 at 10:52 AM, Neel Patel <[email protected]>
> wrote:
>
>> Hi Akshay,
>>
>> Due to above commit, when user "Drop" any database it gives exception in
>> browser console.
>> Check attached screenshot.
>>
>> Thanks,
>> Neel Patel
>>
>>
>>
>> On Wed, Mar 21, 2018 at 2:08 PM, Dave Page <[email protected]> wrote:
>>
>>> Fix a number of broken connection detection scenarios.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=637f3b9d1a54df8b9a1bfad9e26f27fdea407683
>>> Author: Akshay Joshi <[email protected]>
>>>
>>> Modified Files
>>> --------------
>>> web/pgadmin/dashboard/static/js/dashboard.js | 58
>>> ++++++++++++--------
>>> web/pgadmin/static/js/sqleditor/execute_query.js | 62
>>> +++++++++++----------
>>> .../js/sqleditor/is_new_transaction_required.js | 9 ++++
>>> web/pgadmin/tools/sqleditor/__init__.py | 4 +-
>>> web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 20 ++++---
>>> .../tools/sqleditor/tests/test_start_query_tool.py | 2 +-
>>> .../tools/sqleditor/utils/start_running_query.py | 63
>>> ++++++++++------------
>>> .../utils/tests/test_start_running_query.py | 15 +++++-
>>> .../user_management/static/js/user_management.js | 13 ++++-
>>> .../utils/driver/psycopg2/server_manager.py | 1 +
>>> .../javascript/sqleditor/execute_query_spec.js | 48
>>> ++++++++++++-----
>>> .../sqleditor/is_new_transaction_required_spec.js | 14 ++---
>>> 12 files changed, 195 insertions(+), 114 deletions(-)
>>>
>>>
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2018-04-05 09:12 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-03-21 08:38 pgAdmin 4 commit: Fix a number of broken connection detection scenarios Dave Page <[email protected]>
2018-04-05 05:22 ` Neel Patel <[email protected]>
2018-04-05 05:57 ` Akshay Joshi <[email protected]>
2018-04-05 09:12 ` Neel Patel <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox