public inbox for [email protected]  

help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin3][Extension]: Wrong SQL generated
Date: Sun, 24 Jan 2016 19:23:00 +0530
Message-ID: <CACCA4P0dr2MoPHRX_Px3UroVBd3UJ8m2VEC2DGmCy1wogDQjTw@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D8hPH9Hj8mAq+XorWvV7N4xKn5g3PCUj-x6UhhCReiPmQ@mail.gmail.com>
References: <CAM5-9D8hPH9Hj8mAq+XorWvV7N4xKn5g3PCUj-x6UhhCReiPmQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

Please find attached patch file for the issue mentioned below.

*Issue:- *
When user "Edit" any existing extension module property, and try to change
the schema and version field to blank then SQL should not be generated for
the blank field.

Above issue is fixed with attached patch file.

Do review it and let us know for any comments.

Thanks,
Neel Patel

On Mon, Jan 18, 2016 at 4:33 PM, Surinder Kumar <
[email protected]> wrote:

> Hi all,
>
>
> While implementing Extension module in pgAdmin4, I came to know that there
> is an bug in pgadmin3.
>
> Following are the steps to reproduce it:
> 1. Edit an existing extension.
> 2. In definition tab, set schema and version fields to empty.
> 3. In SQL tab, it generates an sql for the changes made which is wrong, it
> shouldn't generate sql for the schema and version field if it is kept
> empty, both fields should be validated.
>
>
> Below is the wrong SQL generated:
>
> *ALTER EXTENSION btree_gin*
> *  SET SCHEMA ;*
> *ALTER EXTENSION btree_gin*
> *  UPDATE TO ;*
>
>
> Let me know for any comments.
>
> Thanks
> Surinder Kumar
>


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] extension_fix.patch (897B, 3-extension_fix.patch)
  download | inline diff:
diff --git a/pgadmin/dlg/dlgExtension.cpp b/pgadmin/dlg/dlgExtension.cpp
index cfa62a3..7c2362e 100644
--- a/pgadmin/dlg/dlgExtension.cpp
+++ b/pgadmin/dlg/dlgExtension.cpp
@@ -180,10 +180,10 @@ wxString dlgExtension::GetSql()
 	if (extension)
 	{
 		// edit mode
-		if (cbObjectsSchema->GetValue() != extension->GetSchemaStr())
+		if (!cbObjectsSchema->GetValue().IsEmpty() && cbObjectsSchema->GetValue() != extension->GetSchemaStr())
 			sql += wxT("ALTER EXTENSION ") + qtIdent(extension->GetName())
 			       +  wxT("\n  SET SCHEMA ") + qtIdent(cbObjectsSchema->GetValue()) + wxT(";\n");
-		if (cbVersion->GetValue() != extension->GetVersion())
+		if (!cbVersion->GetValue().IsEmpty() && cbVersion->GetValue() != extension->GetVersion())
 			sql += wxT("ALTER EXTENSION ") + qtIdent(extension->GetName())
 			       +  wxT("\n  UPDATE TO ") + qtIdent(cbVersion->GetValue()) + wxT(";\n");
 	}

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin3][Extension]: Wrong SQL generated
  In-Reply-To: <CACCA4P0dr2MoPHRX_Px3UroVBd3UJ8m2VEC2DGmCy1wogDQjTw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox