public inbox for [email protected]  

help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: Dave Page <[email protected]>
Cc: Nikolai Zhubr <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390
Date: Tue, 5 Jan 2016 17:54:06 +0530
Message-ID: <CACCA4P1Rm1Z1em+XMO5qy3Ne=ckyMMbUeffsNKPWti1z7Abziw@mail.gmail.com> (raw)
In-Reply-To: <CACCA4P1_OuwX5RLcQK==FEG5dL8mUt=r56MwNGyMfb3G8cqODw@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CA+OCxoz4ZaoKk7p77H6qZ-CpFVnTyxVj9uLxar5Fqge3Tmeg1g@mail.gmail.com>
	<CACCA4P1_OuwX5RLcQK==FEG5dL8mUt=r56MwNGyMfb3G8cqODw@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

Please find attached patch file with below fix.
 - Return value of the function will be displayed as "SETOF record" instead
of "SETOF SETOF record" under SQL tab within properties window.

Let me know for any comments.

Thanks,
Neel Patel

On Tue, Jan 5, 2016 at 5:08 PM, Neel Patel <[email protected]>
wrote:

> Hi Dave,
>
> Sure, I will look into this issue.
>
> Thanks,
> Neel Patel
>
> On Tue, Jan 5, 2016 at 4:47 PM, Dave Page <[email protected]> wrote:
>
>> Neel, can you look at this please?
>>
>> Thanks.
>>
>> On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <[email protected]>
>> wrote:
>> > Hi all,
>> >
>> > Running 1.22-rc1 now I observe that this commit has apparently still not
>> > solved the issue in at least one place. That is:
>> >
>> > - "RETURNS SETOF record" is correctly displayed in SQL panel now.
>> >
>> > - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL
>> tab
>> > within the properties window (effectively preventing set-returning
>> function
>> > to be changed in any way through the properties window).
>> >
>> >
>> > Thank you,
>> > Nikolai
>> >
>> > 12.10.2015 5:33, Ashesh Vashi:
>> >>
>> >> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use
>> >> pg_get_function_result(..) function to identify the return type of the
>> >> function, hence - we don't need to add SETOF keyword explicitly, when a
>> >> function returns set of records.
>> >>
>> >> Branch
>> >> ------
>> >> master
>> >>
>> >> Details
>> >> -------
>> >>
>> >>
>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e...
>> >>
>> >> Modified Files
>> >> --------------
>> >> pgadmin/schema/pgFunction.cpp |    2 --
>> >> 1 file changed, 2 deletions(-)
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list ([email protected])
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] function_sql_setof.patch (432B, 3-function_sql_setof.patch)
  download | inline diff:
diff --git a/pgadmin/dlg/dlgFunction.cpp b/pgadmin/dlg/dlgFunction.cpp
index 119a92c..a133df7 100644
--- a/pgadmin/dlg/dlgFunction.cpp
+++ b/pgadmin/dlg/dlgFunction.cpp
@@ -932,9 +932,6 @@ wxString dlgFunction::GetSql()
 		if (!isProcedure)
 		{
 			sql += wxT(" RETURNS ");
-			if (chkSetof->GetValue() && !cbReturntype->GetValue().StartsWith(wxT("TABLE")))
-				sql += wxT("SETOF ");
-
 			sql += cbReturntype->GetValue();
 		}
 

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390
  In-Reply-To: <CACCA4P1Rm1Z1em+XMO5qy3Ne=ckyMMbUeffsNKPWti1z7Abziw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox