public inbox for [email protected]  

help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: File Manager & Backform FileControl
Date: Wed, 27 Apr 2016 21:15:04 +0530
Message-ID: <CACCA4P22BrRBfxTvSRYaPb_VaOA+8HbNLkZDM=w-H8VXeo6HNQ@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D8GX9gNZp95K11rfnpnn4msEH=F6hhZNpBE_WLX46vicg@mail.gmail.com>
References: <CAM5-9D8GX9gNZp95K11rfnpnn4msEH=F6hhZNpBE_WLX46vicg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Surinder,

I have applied the patch file and below are some observations.

   - When we create the new folder and hit the enter then we are getting
   the below error.

                  TypeError: argument of type 'NoneType' is not iterable

   - I have just added the new control in "Import" dialog and observed that
   new control is getting added in new tab called "General". I think it should
   not create the new "General" tab.
   - "Select" and "Cancel" buttons font is different then other dialogs.


Thanks,
Neel Patel

On Wed, Apr 27, 2016 at 6:18 PM, Surinder Kumar <
[email protected]> wrote:

> Hi,
>
> The patch is for *File Manager and Backform FileControl*.
>
> *File Manager:* It allows user to store their files at one place. The
> user can set path to this directory in preferences which file manger will
> use.
>
> It will be used by various modules of pgAdmin4 such as
> *import data from file, query tool, backup & recovery tool* so on.. It
> allows user to perform various operations such as:
>
>    - File deletion
>    - File upload
>    - Create new directory
>    - File rename
>    - File download and
>    - List files & folders in list and grid view.
>
> *FileControl: *This control is used with *File Manager. *It can be used
> for:
>
>    - File Selection
>    - Folder Selection
>    - File Creation
>    - Storage Manager Dialog.( it supports all operations listed above).
>
>
> Usage*:*
>
> schema:[{
>   id: 'select_file', label: '{{ _('Select File')}}',
>   type: 'text', *control*: *Backform.FileControl*,
>   *dialog_type: 'select_file'*, *supp_types: ['*', 'pdf', 'text',
> 'patch', 'py']*
> }
>
> Where:
>
>    - *control* - It should be *Backform.FileControl*
>    - *dialog_type *- the type of dialog to use.
>    - options can be:  *select_file, select_folder, create_file &
>    storage_dialog*.
>    - *supp_types(*not mandatory) - the types of files allowed to show and
>    upload.
>
> Please review the patch and let me know for the review comments.
>
>
> Thanks
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: File Manager & Backform FileControl
  In-Reply-To: <CACCA4P22BrRBfxTvSRYaPb_VaOA+8HbNLkZDM=w-H8VXeo6HNQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox