public inbox for [email protected]
help / color / mirror / Atom feedFrom: Neel Patel <[email protected]>
To: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: RM4292 - Dark mode support for Windows/macOS
Date: Mon, 20 Apr 2020 18:58:56 +0530
Message-ID: <CACCA4P2VRQLbhzyrWFUHXTy+Jw-+dg3nMXkruFgLJ8zLxd2Gug@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxox-df5Jx_68SJ=zbaXsWCZ9drH5WnTAiL0wdc0v3X_VgA@mail.gmail.com>
References: <CA+OCxoyiLYcN0N00nFPT9YCOFo8HT47rcoidccq2N5fDJFuqtQ@mail.gmail.com>
<CANxoLDdFpBpAg_V5r5M2ni9ycQzr-vhRkeQmMUfqEMYZXq-pZw@mail.gmail.com>
<CACCA4P1U8iLJWDM4_by0+HC9oPyUrrfArsu522FgWC6+sjjzWA@mail.gmail.com>
<CA+OCxowhYTCS0g7q=9BVi-Nd0=++3dWugAeZQTRzEVikwSdosA@mail.gmail.com>
<CACCA4P0L-0PS_8-9i-sa4ECvH16kK6eJSgUcMHP57fTyzBHCBA@mail.gmail.com>
<CA+OCxoyC1+id7C8ii5A+sfE8Kc+SQSNMrQ1FtGqn7hOaJG_MGg@mail.gmail.com>
<CACCA4P1RUSK+7=nYB6gf9oKNOa=QoaDSdUBt06LMaw2VOdFyFA@mail.gmail.com>
<CA+OCxox-df5Jx_68SJ=zbaXsWCZ9drH5WnTAiL0wdc0v3X_VgA@mail.gmail.com>
Hi,
In windows, I am able to reproduce it with my dev environment and after
copying "Qt5Svg.dll", it renders the checkbox and for Mac build, we should
copy theme components in "Resources" folder which might solve the problem
and update the patch accordingly.
Once snapshot build is ready, I will verify with the same. Do review it.
Thanks,
Neel Patel
On Wed, Apr 15, 2020 at 7:12 PM Dave Page <[email protected]> wrote:
>
>
> On Wed, Apr 15, 2020 at 2:11 PM Neel Patel <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> On Wed, Apr 15, 2020 at 5:04 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Thu, Apr 9, 2020 at 5:56 PM Neel Patel <[email protected]>
>>> wrote:
>>>
>>>>
>>>>
>>>>>> - Checkbox is not visible in Configure window UI as per below
>>>>>> screenshot. Are you able to see on Mac ? If no, I can take a look at it.
>>>>>>
>>>>>> [image: Screenshot 2020-04-09 at 5.05.25 PM.png]
>>>>>>
>>>>>
>>>>> No, that works on Mac. If you can look at it that would be great (are
>>>>> the SVGs from the patch in your filesystem?):
>>>>>
>>>>
>>>> Yes, all SVGs from the patch are there. I will take a look.
>>>>
>>>>
>>>>>
>>>>> [image: Screenshot 2020-04-09 at 17.47.39.png]
>>>>>
>>>>
>>> So interestingly, with the snapshot build I now see this:
>>>
>>> [image: Screenshot 2020-04-15 at 12.34.02.png]
>>>
>>> Any idea what's going on?
>>>
>>
>> All svg files and qss reside along with the application ?
>> Initially I got this issue and when I copied the qss and svg files along
>> with the application, it resolved the issue but again I will double-check
>> and update on this.
>>
>
> Actually, no - I don't see them in the appbundle.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachments:
[image/png] Screenshot 2020-04-09 at 5.05.25 PM.png (74.0K, 3-Screenshot%202020-04-09%20at%205.05.25%20PM.png)
download | view image
[image/png] Screenshot 2020-04-09 at 17.47.39.png (398.3K, 4-Screenshot%202020-04-09%20at%2017.47.39.png)
download | view image
[image/png] Screenshot 2020-04-15 at 12.34.02.png (455.0K, 5-Screenshot%202020-04-15%20at%2012.34.02.png)
download | view image
[application/octet-stream] RM_5402.patch (1.3K, 6-RM_5402.patch)
download | inline diff:
diff --git a/Make.bat b/Make.bat
index 884778981..b42238a36 100644
--- a/Make.bat
+++ b/Make.bat
@@ -276,6 +276,7 @@ REM Main build sequence Ends
COPY "%QTDIR%\bin\Qt5Gui.dll" "%PGBUILDPATH%\runtime" > nul || EXIT /B 1
COPY "%QTDIR%\bin\Qt5Widgets.dll" "%PGBUILDPATH%\runtime" > nul || EXIT /B 1
COPY "%QTDIR%\bin\Qt5Network.dll" "%PGBUILDPATH%\runtime" > nul || EXIT /B 1
+ COPY "%QTDIR%\bin\Qt5Svg.dll" "%PGBUILDPATH%\runtime" > nul || EXIT /B 1
IF EXIST "%QTDIR%\bin\libgcc_s_dw2-1.dll" COPY "%QTDIR%\bin\libgcc_s_dw2-1.dll" "%PGBUILDPATH%\runtime" > nul || EXIT /B 1
IF EXIST "%QTDIR%\bin\libstdc++-6.dll" COPY "%QTDIR%\bin\libstdc++-6.dll" "%PGBUILDPATH%\runtime" > nul || EXIT /B 1
IF EXIST "%QTDIR%\bin\libwinpthread-1.dll" COPY "%QTDIR%\bin\libwinpthread-1.dll" "%PGBUILDPATH%\runtime" > nul || EXIT /B 1
diff --git a/pkg/mac/build.sh b/pkg/mac/build.sh
index 7feb29431..8308a82d1 100755
--- a/pkg/mac/build.sh
+++ b/pkg/mac/build.sh
@@ -153,7 +153,7 @@ _build_runtime() {
${QMAKE} || { echo qmake failed; exit 1; }
make || { echo make failed; exit 1; }
cp -r pgAdmin4.app "${BUILDROOT}/${APP_BUNDLE_NAME}"
- cp -r dark light dark.qss light.qss "${BUILDROOT}/"
+ cp -r dark light dark.qss light.qss "${BUILDROOT}/${APP_BUNDLE_NAME}/Contents/Resources/"
}
_build_doc() {
view thread (26+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: RM4292 - Dark mode support for Windows/macOS
In-Reply-To: <CACCA4P2VRQLbhzyrWFUHXTy+Jw-+dg3nMXkruFgLJ8zLxd2Gug@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox