public inbox for [email protected]  

help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Observed bug in pgAdmin3
Date: Sun, 24 Jan 2016 19:17:26 +0530
Message-ID: <CACCA4P3L+C_Lvm5ri3oV2DXjiuEGsbMLeFgMVEfo4xZ55m3duw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

We have fixed the issue as mentioned below.

*Issue :-*
When we create any collation then two times schema name was appended to
query.

*Fix:-*
With this fix, schema name will appended only one time and create query for
collation will execute correctly.

Please find attached patch file. Review it and let us know for any comments.

Thanks,
Neel Patel

On Mon, Jan 4, 2016 at 12:28 PM, Murtuza Zabuawala <
[email protected]> wrote:

> Hi All,
>
> I observed an issue while creating new collation (in schemas).
>
> Steps to reproduce,
> 1) Connect to postgres database
> 2) Expand 'postgres' database
> 3) Expand 'schemas'
> 4) Expand 'Collations'
> 5) Right click & Click "New Collation..."
>
> Provide > Properties:
>   Name: test-11
>   Owner: postgres
>   Schema: pg_toast
>
> Provide > Definition:
>   Copy collation: pg_catalog."en_IN.utf8"
>
> 6)
> Now click on SQL tab and you will see the wrong sql created, schema name
> is appended twice in alter statement.
>
> CREATE COLLATION pg_toast."test-11" FROM pg_catalog."en_IN.utf8";
> ALTER COLLATION *pg_toast."pg_toast.""test-11"""*
>   OWNER TO postgres;
>
>
> Let me know for more information.
>
> Regards,
> Murtuza Zabuawala
>
>


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] collation_fix.patch (513B, 3-collation_fix.patch)
  download | inline diff:
diff --git a/pgadmin/dlg/dlgCollation.cpp b/pgadmin/dlg/dlgCollation.cpp
index 47ad3c7..432efdf 100644
--- a/pgadmin/dlg/dlgCollation.cpp
+++ b/pgadmin/dlg/dlgCollation.cpp
@@ -178,7 +178,7 @@ wxString dlgCollation::GetSql()
 		}
 		sql += wxT(";\n");
 
-		AppendOwnerNew(sql, wxT("COLLATION ") + schema->GetQuotedPrefix() + qtIdent(name));
+		AppendOwnerNew(sql, wxT("COLLATION ") + name);
 	}
 	AppendComment(sql, wxT("COLLATION ") + qtIdent(cbSchema->GetValue()) + wxT(".") + qtIdent(GetName()), collation);
 

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Observed bug in pgAdmin3
  In-Reply-To: <CACCA4P3L+C_Lvm5ri3oV2DXjiuEGsbMLeFgMVEfo4xZ55m3duw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox