public inbox for [email protected]  
help / color / mirror / Atom feed
From: Neel Patel <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][patch]: Fix for RM 1320
Date: Mon, 25 Jul 2016 11:31:53 +0530
Message-ID: <CACCA4P3dHgkPte+NYf3yMCXGm=zHo5aEaK5CaSe2n1Hmz2Zg2w@mail.gmail.com> (raw)
In-Reply-To: <CACCA4P0v_8JGTgqwmeL74Bfm1g7UmtCzw79_nD6g4BNhRPvjyg@mail.gmail.com>
References: <CACCA4P0v_8JGTgqwmeL74Bfm1g7UmtCzw79_nD6g4BNhRPvjyg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Adding more details.

*Root cause:-*

When user change schema of already created fdw extension then while
creating the new fdw we should append the <schema_name>.<fdw_handler_name>.
Previously we added only <fdw_handler_name> so while executing the query it
will not be able to find fdw handler name without schema name.

e.g. If user changed the fdw handler 'postgres_fdw_handler' under schema
'test' then we should display the handler  name under fdw as "test.
 postgres_fdw_handler".

*Solution:-*

With this patch, we have added <schema_name>.<fdw_handler_name> so while
creating or updating the fdw, proper sql will be generated.

Thanks,
Neel Patel


On Mon, Jul 25, 2016 at 11:02 AM, Neel Patel <[email protected]>
wrote:

> Hi,
>
> Please find attached patch file for the fix of RM- 1320.
>
> RM-1320 - Unable to create foreign data wrapper when user change the
> schema of extension 'postgres_fdw_handler'.
>
> Thanks,
> Neel Patel
>


view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][patch]: Fix for RM 1320
  In-Reply-To: <CACCA4P3dHgkPte+NYf3yMCXGm=zHo5aEaK5CaSe2n1Hmz2Zg2w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox