public inbox for [email protected]
help / color / mirror / Atom feedFrom: Joao De Almeida Pereira <[email protected]>
To: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: Neethu Mariya Joy <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Bug #3083 fix
Date: Thu, 29 Mar 2018 15:29:20 +0000
Message-ID: <CAE+jja=Pa3QL2XpHQTmaJP1qpvuNy9Mj6U=4BKNNQ4ip7HGE3A@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozsQr88HoxoCRXsxqi-7nQ6EGx3MJimqXR897GiL5WcfQ@mail.gmail.com>
References: <CAAdJd1OqoYe1=FZkZrO-WYEYH_asph3GP8u7a6XdjmQ7FwAaiA@mail.gmail.com>
<CAE+jjamnK3vVZYqs_6+4yVxUPgpMbgM9NM06m1L4ytaMbkXpVQ@mail.gmail.com>
<CANxoLDdrGtD76fwSe-b3swcbFcrcm8Me-s5Du+F_xyCYfCg_9A@mail.gmail.com>
<CAE+jjamhfMrW5p3rsDddDCdJD_i+RU+O=i2sTNeLf=TV_J==WQ@mail.gmail.com>
<CA+OCxozsQr88HoxoCRXsxqi-7nQ6EGx3MJimqXR897GiL5WcfQ@mail.gmail.com>
Hi Dave,
That looks like in the surrounding area of the change. We run our pipeline
and everything was green.
Can you provide more details, which python version are you using? OS?
Thanks
Joao
On Thu, Mar 29, 2018 at 9:03 AM Dave Page <[email protected]> wrote:
> Hi
>
> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
> [email protected]> wrote:
>
>> Hey Akshay and Neethu
>>
>> We refactored the patch to add tests for the resize feature. We were
>> able to write test cases for the drag event by using spies and setting the
>> rect dimensions. In cases like this, we can just test some components in
>> order to have enough confidence in the code. So we isolated the function
>> that implements the behavior of this feature and tested that it was
>> performing as expected.
>>
>> We ran the patch through the pipelines and all of the tests passed.
>>
>
> I'm consistently seeing the feature test failure below with this patch
> applied:
>
> ======================================================================
> FAIL: runTest
> (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
> Validate Insert, Update operations in View/Edit data with given test data
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 125, in runTest
> self._verify_row_data(True)
> File
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 325, in _verify_row_data
> self.assertEquals(cells[idx], config_data[str(idx)][1])
> AssertionError: u'[null]' != u'1'
> - [null]
> + 1
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Bug #3083 fix
In-Reply-To: <CAE+jja=Pa3QL2XpHQTmaJP1qpvuNy9Mj6U=4BKNNQ4ip7HGE3A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox