public inbox for [email protected]  

help / color / mirror / Atom feed

From: Joao Pedro De Almeida Pereira <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Issue with SlickGrid
Date: Wed, 26 Apr 2017 16:53:08 -0400
Message-ID: <CAE+jjakiOhWWPTUxLMGGCuVhL=3pKuZjFfya5WVj0snegCZ-kQ@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hello Hackers,

While doing some changes to the Query Results we found out that there was a
issue with Slick grid.

The issue that we found was with the CellSelectModel, behaved differently
when pressing Ctrl and Command(Mac). We created a PR
<https://github.com/6pac/SlickGrid/pull/100; with the change to changes the
behavior of the plugin.

When this PR is applied to the SlickGrid library we need to apply it to the
current version of SlickGrid that we have vendorized.
According to the libraries.txt file we are in version 2.2.4 of the library
but a diff between our code and the libraries version 2.2.4 shows
differences in the code.

Did we do any change to SlickGrid library that is vendorized? Or is just
the information in libraries.txt that is incorrect?
Does anyone know any problem if we bump the version of SlickGrid to the
newer version after the PR is applied?

Thanks
Joao

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: Issue with SlickGrid
  In-Reply-To: <CAE+jjakiOhWWPTUxLMGGCuVhL=3pKuZjFfya5WVj0snegCZ-kQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox