public inbox for [email protected]
help / color / mirror / Atom feedFrom: Joao De Almeida Pereira <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed
Date: Fri, 09 Feb 2018 14:35:39 +0000
Message-ID: <CAE+jjam6bc4HeZgFbRayxXOJVft6J7s=Xb7M8i54mX7tNCp08Q@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyT9yQU-ayjRa94UMaekGP7QhB3CNqaJ_A-j8t+4Jb4FA@mail.gmail.com>
References: <CAE+jjakOhMJBMqsUaQuL9w4an0V4Q4nvY51K3GqWzm8jbj9cog@mail.gmail.com>
<CA+OCxowBzhOaJf1_w1gPhOR4TH3bdtKBsdqETAqSwK0n2GWezg@mail.gmail.com>
<CA+OCxoyT9yQU-ayjRa94UMaekGP7QhB3CNqaJ_A-j8t+4Jb4FA@mail.gmail.com>
Hello,
Attached you can find the fix for the current pronlem
On Fri, Feb 9, 2018 at 7:29 AM Dave Page <[email protected]> wrote:
> Hi Joao,
>
> It looks like Jenkins has taken umbrage to this change, at least with
> Python 3.x. Can you take a look please?
>
> https://jenkins.pgadmin.org/
>
> Thanks.
>
> On Fri, Feb 9, 2018 at 11:54 AM, Dave Page <[email protected]> wrote:
>
>> Thanks, patches applied.
>>
>> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>> This is quite a big patch in order to solve the problem with the Explain
>>> Plan.
>>>
>>> We sent 2 patches that have the following:
>>> *- update-javascript-packages.diff *
>>> Add package:
>>> is-docker to select a specific setting when running the Chrome
>>> tests in
>>> Docker
>>>
>>> Upgrade the version of:
>>> - babel-loader
>>> - extract-text-webpack-plugin
>>> - jasmine-core
>>> - jasmine-enzyme
>>> - moment
>>> *- explain-plan-greenplum.diff*
>>> Extract SQLEditor.execute and SQLEditor._poll into their own files and
>>> add test around them
>>> Extract SQLEditor backend functions that start executing query to
>>> their own files and add tests around it
>>> Move the Explain SQL from the front-end and now pass the Explain plan
>>> parameters as a JSON object in the start query call.
>>> Extract the compile_template_name into a function that can be used by
>>> the different places that try to select the version of the template and the
>>> server type
>>>
>>>
>>> Thanks
>>> Joao
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachments:
[application/octet-stream] correct-tests0in-python-3.6 (951B, 3-correct-tests0in-python-3.6)
download
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed
In-Reply-To: <CAE+jjam6bc4HeZgFbRayxXOJVft6J7s=Xb7M8i54mX7tNCp08Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox